From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40809)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bkpTS-0004JU-Hm
	for qemu-devel@nongnu.org; Fri, 16 Sep 2016 05:30:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bkpTO-0000rX-RX
	for qemu-devel@nongnu.org; Fri, 16 Sep 2016 05:30:21 -0400
Received: from mail-wm0-f54.google.com ([74.125.82.54]:36072)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1bkpTO-0000r7-L1
	for qemu-devel@nongnu.org; Fri, 16 Sep 2016 05:30:18 -0400
Received: by mail-wm0-f54.google.com with SMTP id b187so26650672wme.1
	for <qemu-devel@nongnu.org>; Fri, 16 Sep 2016 02:30:18 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <20160915090042.6440.22516.stgit@PASHA-ISP>
	<20160915090105.6440.95131.stgit@PASHA-ISP>
	<cf426c74-50db-2d21-e7a8-976d8cdb49e4@redhat.com>
	<001b01d20fef$ca246970$5e6d3c50$@ru>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <b94d3eaa-f21b-9cfa-0cac-729ac7bfdd88@redhat.com>
Date: Fri, 16 Sep 2016 11:29:16 +0200
MIME-Version: 1.0
In-Reply-To: <001b01d20fef$ca246970$5e6d3c50$@ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 04/10] replay: save/load initial state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <dovgaluk@ispras.ru>, 'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, quintela@redhat.com, jasowang@redhat.com, mst@redhat.com, agraf@suse.de, david@gibson.dropbear.id.au



On 16/09/2016 09:56, Pavel Dovgalyuk wrote:
>>> > > +{
>>> > > +    if (replay_mode == REPLAY_MODE_RECORD) {
>>> > > +        QDict *opts = qdict_new();
>>> > > +        qdict_put(opts, "name", qstring_from_str("replay_init"));
>>> > > +        hmp_savevm(cur_mon, opts);
>>> > > +        QDECREF(opts);
>>> > > +    } else if (replay_mode == REPLAY_MODE_PLAY) {
>>> > > +        load_vmstate("replay_init");
>> > 
>> > See my other message about a suggestion to remove the hardcoded snapshot
>> > name.
>> > 
>> > Also, I think the return value of load_vmstate and hmp_savevm should be
>> > checked.
> 
> Load may be unsuccessful when the system is started with temporary overlay file.
> This is ok.

This seems to be in favor of using a rrsnapshot option instead.  Using
rrsnapshot for temporary overlay would make little sense.

Paolo