* [Qemu-devel] [PATCH] configure: Add xkbcommon configure options
@ 2019-09-14 14:51 James Le Cuirot
2019-09-16 8:15 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-09-16 12:11 ` [Qemu-devel] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 7+ messages in thread
From: James Le Cuirot @ 2019-09-14 14:51 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, James Le Cuirot
This dependency is currently "automagic", which is bad for distributions.
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
---
configure | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/configure b/configure
index 30aad233d1..30544f52e6 100755
--- a/configure
+++ b/configure
@@ -1521,6 +1521,10 @@ for opt do
;;
--disable-libpmem) libpmem=no
;;
+ --enable-xkbcommon) xkbcommon=yes
+ ;;
+ --disable-xkbcommon) xkbcommon=no
+ ;;
*)
echo "ERROR: unknown option $opt"
echo "Try '$0 --help' for more information"
@@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
capstone capstone disassembler support
debug-mutex mutex debugging support
libpmem libpmem support
+ xkbcommon xkbcommon support
NOTE: The object files are built at the place where configure is launched
EOF
--
2.23.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
2019-09-14 14:51 [Qemu-devel] [PATCH] configure: Add xkbcommon configure options James Le Cuirot
@ 2019-09-16 8:15 ` Laurent Vivier
2019-09-19 8:37 ` Gerd Hoffmann
2019-09-16 12:11 ` [Qemu-devel] " Philippe Mathieu-Daudé
1 sibling, 1 reply; 7+ messages in thread
From: Laurent Vivier @ 2019-09-16 8:15 UTC (permalink / raw)
To: James Le Cuirot, qemu-devel; +Cc: qemu-trivial, Gerd Hoffmann
Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
> This dependency is currently "automagic", which is bad for distributions.
>
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
> configure | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/configure b/configure
> index 30aad233d1..30544f52e6 100755
> --- a/configure
> +++ b/configure
> @@ -1521,6 +1521,10 @@ for opt do
> ;;
> --disable-libpmem) libpmem=no
> ;;
> + --enable-xkbcommon) xkbcommon=yes
> + ;;
> + --disable-xkbcommon) xkbcommon=no
> + ;;
> *)
> echo "ERROR: unknown option $opt"
> echo "Try '$0 --help' for more information"
> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
> capstone capstone disassembler support
> debug-mutex mutex debugging support
> libpmem libpmem support
> + xkbcommon xkbcommon support
>
> NOTE: The object files are built at the place where configure is launched
> EOF
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
cc: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
2019-09-16 8:15 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2019-09-19 8:37 ` Gerd Hoffmann
2019-09-19 10:16 ` Laurent Vivier
0 siblings, 1 reply; 7+ messages in thread
From: Gerd Hoffmann @ 2019-09-19 8:37 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-trivial, James Le Cuirot, qemu-devel
On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote:
> Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
> > This dependency is currently "automagic", which is bad for distributions.
> >
> > Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> > ---
> > configure | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/configure b/configure
> > index 30aad233d1..30544f52e6 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1521,6 +1521,10 @@ for opt do
> > ;;
> > --disable-libpmem) libpmem=no
> > ;;
> > + --enable-xkbcommon) xkbcommon=yes
> > + ;;
> > + --disable-xkbcommon) xkbcommon=no
> > + ;;
> > *)
> > echo "ERROR: unknown option $opt"
> > echo "Try '$0 --help' for more information"
> > @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
> > capstone capstone disassembler support
> > debug-mutex mutex debugging support
> > libpmem libpmem support
> > + xkbcommon xkbcommon support
> >
> > NOTE: The object files are built at the place where configure is launched
> > EOF
> >
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>
> cc: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
2019-09-19 8:37 ` Gerd Hoffmann
@ 2019-09-19 10:16 ` Laurent Vivier
2019-09-19 11:01 ` Gerd Hoffmann
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Vivier @ 2019-09-19 10:16 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, James Le Cuirot, qemu-devel
Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :
> On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote:
>> Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
>>> This dependency is currently "automagic", which is bad for distributions.
>>>
>>> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
>>> ---
>>> configure | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/configure b/configure
>>> index 30aad233d1..30544f52e6 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -1521,6 +1521,10 @@ for opt do
>>> ;;
>>> --disable-libpmem) libpmem=no
>>> ;;
>>> + --enable-xkbcommon) xkbcommon=yes
>>> + ;;
>>> + --disable-xkbcommon) xkbcommon=no
>>> + ;;
>>> *)
>>> echo "ERROR: unknown option $opt"
>>> echo "Try '$0 --help' for more information"
>>> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>>> capstone capstone disassembler support
>>> debug-mutex mutex debugging support
>>> libpmem libpmem support
>>> + xkbcommon xkbcommon support
>>>
>>> NOTE: The object files are built at the place where configure is launched
>>> EOF
>>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>>
>> cc: Gerd Hoffmann <kraxel@redhat.com>
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>
Gerd,
do you take this through your ui branch or should I take through the
trivial patches branch?
Thanks,
Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
2019-09-19 10:16 ` Laurent Vivier
@ 2019-09-19 11:01 ` Gerd Hoffmann
2019-09-19 11:47 ` Laurent Vivier
0 siblings, 1 reply; 7+ messages in thread
From: Gerd Hoffmann @ 2019-09-19 11:01 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-trivial, James Le Cuirot, qemu-devel
On Thu, Sep 19, 2019 at 12:16:43PM +0200, Laurent Vivier wrote:
> Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :
> > On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote:
> >> Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
> >>> This dependency is currently "automagic", which is bad for distributions.
> >>>
> >>> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> >>> ---
> >>> configure | 5 +++++
> >>> 1 file changed, 5 insertions(+)
> >>>
> >>> diff --git a/configure b/configure
> >>> index 30aad233d1..30544f52e6 100755
> >>> --- a/configure
> >>> +++ b/configure
> >>> @@ -1521,6 +1521,10 @@ for opt do
> >>> ;;
> >>> --disable-libpmem) libpmem=no
> >>> ;;
> >>> + --enable-xkbcommon) xkbcommon=yes
> >>> + ;;
> >>> + --disable-xkbcommon) xkbcommon=no
> >>> + ;;
> >>> *)
> >>> echo "ERROR: unknown option $opt"
> >>> echo "Try '$0 --help' for more information"
> >>> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
> >>> capstone capstone disassembler support
> >>> debug-mutex mutex debugging support
> >>> libpmem libpmem support
> >>> + xkbcommon xkbcommon support
> >>>
> >>> NOTE: The object files are built at the place where configure is launched
> >>> EOF
> >>>
> >>
> >> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> >>
> >> cc: Gerd Hoffmann <kraxel@redhat.com>
> >
> > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> >
>
> Gerd,
>
> do you take this through your ui branch or should I take through the
> trivial patches branch?
Trivial branch is fine (have not picked this up b/c I saw qemu-trivial
on cc).
cheers,
Gerd
>
> Thanks,
> Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Add xkbcommon configure options
2019-09-19 11:01 ` Gerd Hoffmann
@ 2019-09-19 11:47 ` Laurent Vivier
0 siblings, 0 replies; 7+ messages in thread
From: Laurent Vivier @ 2019-09-19 11:47 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, James Le Cuirot, qemu-devel
Le 19/09/2019 à 13:01, Gerd Hoffmann a écrit :
> On Thu, Sep 19, 2019 at 12:16:43PM +0200, Laurent Vivier wrote:
>> Le 19/09/2019 à 10:37, Gerd Hoffmann a écrit :
>>> On Mon, Sep 16, 2019 at 10:15:15AM +0200, Laurent Vivier wrote:
>>>> Le 14/09/2019 à 16:51, James Le Cuirot a écrit :
>>>>> This dependency is currently "automagic", which is bad for distributions.
>>>>>
>>>>> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
>>>>> ---
>>>>> configure | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/configure b/configure
>>>>> index 30aad233d1..30544f52e6 100755
>>>>> --- a/configure
>>>>> +++ b/configure
>>>>> @@ -1521,6 +1521,10 @@ for opt do
>>>>> ;;
>>>>> --disable-libpmem) libpmem=no
>>>>> ;;
>>>>> + --enable-xkbcommon) xkbcommon=yes
>>>>> + ;;
>>>>> + --disable-xkbcommon) xkbcommon=no
>>>>> + ;;
>>>>> *)
>>>>> echo "ERROR: unknown option $opt"
>>>>> echo "Try '$0 --help' for more information"
>>>>> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
>>>>> capstone capstone disassembler support
>>>>> debug-mutex mutex debugging support
>>>>> libpmem libpmem support
>>>>> + xkbcommon xkbcommon support
>>>>>
>>>>> NOTE: The object files are built at the place where configure is launched
>>>>> EOF
>>>>>
>>>>
>>>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>>>>
>>>> cc: Gerd Hoffmann <kraxel@redhat.com>
>>>
>>> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
>>>
>>
>> Gerd,
>>
>> do you take this through your ui branch or should I take through the
>> trivial patches branch?
>
> Trivial branch is fine (have not picked this up b/c I saw qemu-trivial
> on cc).
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Add xkbcommon configure options
2019-09-14 14:51 [Qemu-devel] [PATCH] configure: Add xkbcommon configure options James Le Cuirot
2019-09-16 8:15 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
@ 2019-09-16 12:11 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-09-16 12:11 UTC (permalink / raw)
To: James Le Cuirot, qemu-devel; +Cc: qemu-trivial
On 9/14/19 4:51 PM, James Le Cuirot wrote:
> This dependency is currently "automagic", which is bad for distributions.
>
Fixes: 6a021536e23
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
> configure | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/configure b/configure
> index 30aad233d1..30544f52e6 100755
> --- a/configure
> +++ b/configure
> @@ -1521,6 +1521,10 @@ for opt do
> ;;
> --disable-libpmem) libpmem=no
> ;;
> + --enable-xkbcommon) xkbcommon=yes
> + ;;
> + --disable-xkbcommon) xkbcommon=no
> + ;;
> *)
> echo "ERROR: unknown option $opt"
> echo "Try '$0 --help' for more information"
> @@ -1804,6 +1808,7 @@ disabled with --disable-FEATURE, default is enabled if available:
> capstone capstone disassembler support
> debug-mutex mutex debugging support
> libpmem libpmem support
> + xkbcommon xkbcommon support
>
> NOTE: The object files are built at the place where configure is launched
> EOF
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-19 11:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-14 14:51 [Qemu-devel] [PATCH] configure: Add xkbcommon configure options James Le Cuirot
2019-09-16 8:15 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-09-19 8:37 ` Gerd Hoffmann
2019-09-19 10:16 ` Laurent Vivier
2019-09-19 11:01 ` Gerd Hoffmann
2019-09-19 11:47 ` Laurent Vivier
2019-09-16 12:11 ` [Qemu-devel] " Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).