From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint
Date: Wed, 20 Sep 2017 19:14:01 +0200 [thread overview]
Message-ID: <b957a600-b220-7e2c-a831-3b86b06c5d98@redhat.com> (raw)
In-Reply-To: <20170920114637.42004-19-aik@ozlabs.ru>
On 20/09/2017 13:46, Alexey Kardashevskiy wrote:
> This extends memory_region_transaction_commit() to receive a MR as
> if it is a root MR or its topmost parent is, then we can only rebuild
> its FlatView and update it for address spaces sharing it.
>
> The optimization gets disabled though if there is full update about to
> commit.
>
> memory_region_set_enabled() is a special case here, it does not use
> a hint when MR is being disabled.
>
> On POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings
> down the boot time from 20s to 12s, the total memory footprint
> goes down (17G -> 8G).
I think this is incorrect if MR has an alias (no matter if enabling or
disabling)?
Paolo
next prev parent reply other threads:[~2017-09-20 17:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 11:46 [Qemu-devel] [PATCH qemu v4 00/18] memory: Reduce memory use Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 01/18] exec: Explicitly export target AS from address_space_translate_internal Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 02/18] memory: Open code FlatView rendering Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 03/18] memory: Move FlatView allocation to a helper Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 04/18] memory: Move AddressSpaceDispatch from AddressSpace to FlatView Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 05/18] memory: Remove AddressSpace pointer from AddressSpaceDispatch Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 06/18] memory: Switch memory from using AddressSpace to FlatView Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 07/18] memory: Cleanup after switching " Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 08/18] memory: Rename mem_begin/mem_commit/mem_add helpers Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 09/18] memory: Store physical root MR in FlatView Alexey Kardashevskiy
2017-09-20 17:15 ` Paolo Bonzini
2017-09-21 0:02 ` Alexey Kardashevskiy
2017-09-21 5:22 ` Alexey Kardashevskiy
2017-09-21 6:28 ` Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 10/18] memory: Alloc dispatch tree where topology is generared Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 11/18] memory: Move address_space_update_ioeventfds Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 12/18] memory: Share FlatView's and dispatch trees between address spaces Alexey Kardashevskiy
2017-09-20 17:18 ` Paolo Bonzini
2017-09-20 23:53 ` Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 13/18] memory: Do not allocate FlatView in address_space_init Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 14/18] memory: Add flat views to HMP "info mtree" Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 15/18] memory: Share special empty FlatView Alexey Kardashevskiy
2017-09-20 17:13 ` Paolo Bonzini
2017-09-20 23:48 ` Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 16/18] memory: Get rid of address_space_init_shareable Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 17/18] memory: Create FlatView directly Alexey Kardashevskiy
2017-09-20 17:18 ` Paolo Bonzini
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint Alexey Kardashevskiy
2017-09-20 17:14 ` Paolo Bonzini [this message]
2017-09-21 0:02 ` Alexey Kardashevskiy
2017-09-21 7:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b957a600-b220-7e2c-a831-3b86b06c5d98@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).