From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, s.reiter@proxmox.com,
qemu-devel@nongnu.org, t.lamprecht@proxmox.com,
stefanha@redhat.com, dietmar@proxmox.com
Subject: Re: [PATCH for-5.0 v2 3/3] block: Fix blk->in_flight during blk_wait_while_drained()
Date: Tue, 7 Apr 2020 12:12:11 +0200 [thread overview]
Message-ID: <b96851fa-0fcb-d2d2-ef7d-0ab69933eee3@redhat.com> (raw)
In-Reply-To: <20200406171403.6761-4-kwolf@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 670 bytes --]
On 06.04.20 19:14, Kevin Wolf wrote:
> Waiting in blk_wait_while_drained() while blk->in_flight is increased
> for the current request is wrong because it will cause the drain
> operation to deadlock.
>
> This patch makes sure that blk_wait_while_drained() is called with
> blk->in_flight increased exactly once for the current request, and that
> it temporarily decreases the counter while it waits.
>
> Fixes: cf3129323f900ef5ddbccbe86e4fa801e88c566e
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/block-backend.c | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-04-07 10:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 17:14 [PATCH for-5.0 v2 0/3] block: Fix blk->in_flight during blk_wait_while_drained() Kevin Wolf
2020-04-06 17:14 ` [PATCH for-5.0 v2 1/3] block-backend: Reorder flush/pdiscard function definitions Kevin Wolf
2020-04-07 5:45 ` Vladimir Sementsov-Ogievskiy
2020-04-07 9:22 ` Max Reitz
2020-04-06 17:14 ` [PATCH for-5.0 v2 2/3] block: Increase BB.in_flight for coroutine interfaces Kevin Wolf
2020-04-07 6:41 ` Vladimir Sementsov-Ogievskiy
2020-04-07 8:52 ` Kevin Wolf
2020-04-07 9:10 ` Vladimir Sementsov-Ogievskiy
2020-04-07 9:48 ` Kevin Wolf
2020-04-07 10:00 ` Vladimir Sementsov-Ogievskiy
2020-04-07 10:04 ` Max Reitz
2020-04-07 10:15 ` Max Reitz
2020-04-07 11:13 ` Kevin Wolf
2020-04-07 11:27 ` Max Reitz
2020-04-06 17:14 ` [PATCH for-5.0 v2 3/3] block: Fix blk->in_flight during blk_wait_while_drained() Kevin Wolf
2020-04-07 6:52 ` Vladimir Sementsov-Ogievskiy
2020-04-07 8:59 ` Kevin Wolf
2020-04-07 9:15 ` Vladimir Sementsov-Ogievskiy
2020-04-07 10:12 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96851fa-0fcb-d2d2-ef7d-0ab69933eee3@redhat.com \
--to=mreitz@redhat.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=s.reiter@proxmox.com \
--cc=stefanha@redhat.com \
--cc=t.lamprecht@proxmox.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).