qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Nabih Estefan <nabihestefan@google.com>, <qemu-devel@nongnu.org>
Cc: <peter.maydell@linaro.org>, <steven_lee@aspeedtech.com>,
	<leetroy@gmail.com>, <jamin_lin@aspeedtech.com>,
	<qemu-arm@nongnu.org>
Subject: Re: [PATCH] hw/arm/ast27x0: Fix typo in LTPI address
Date: Mon, 10 Nov 2025 11:22:27 +0100	[thread overview]
Message-ID: <b96ef4b0-a3ee-4723-b75b-cc7e36b703d6@kaod.org> (raw)
In-Reply-To: <20251104233742.2147367-1-nabihestefan@google.com>

On 11/5/25 00:37, Nabih Estefan wrote:
> The address for LTPI has one more 0 that it should, bug introduced in
> commit 91064bea6b2d747a981cb3bd2904e56f443e6c67.
> 
> Signed-off-by: Nabih Estefan <nabihestefan@google.com>
> ---
>   hw/arm/aspeed_ast27x0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Fixes: 91064bea6b2d ("aspeed: ast27x0: Map unimplemented devices in SoC memory")
Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.



> diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
> index c484bcd4e2..1e6f469538 100644
> --- a/hw/arm/aspeed_ast27x0.c
> +++ b/hw/arm/aspeed_ast27x0.c
> @@ -87,11 +87,11 @@ static const hwaddr aspeed_soc_ast2700_memmap[] = {
>       [ASPEED_DEV_UART11]    =  0x14C33A00,
>       [ASPEED_DEV_UART12]    =  0x14C33B00,
>       [ASPEED_DEV_WDT]       =  0x14C37000,
> +    [ASPEED_DEV_LTPI]      =  0x30000000,
>       [ASPEED_DEV_PCIE_MMIO0] = 0x60000000,
>       [ASPEED_DEV_PCIE_MMIO1] = 0x80000000,
>       [ASPEED_DEV_PCIE_MMIO2] = 0xA0000000,
>       [ASPEED_DEV_SPI_BOOT]  =  0x100000000,
> -    [ASPEED_DEV_LTPI]      =  0x300000000,
>       [ASPEED_DEV_SDRAM]     =  0x400000000,
>   };
>   



      parent reply	other threads:[~2025-11-10 10:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 23:37 [PATCH] hw/arm/ast27x0: Fix typo in LTPI address Nabih Estefan
2025-11-05  1:10 ` Jamin Lin
2025-11-05  1:27   ` Kane Chen
2025-11-07 18:28     ` Nabih Estefan
2025-11-08  7:36       ` Cédric Le Goater
2025-11-08 10:50         ` Peter Maydell
2025-11-10 10:22 ` Cédric Le Goater [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b96ef4b0-a3ee-4723-b75b-cc7e36b703d6@kaod.org \
    --to=clg@kaod.org \
    --cc=jamin_lin@aspeedtech.com \
    --cc=leetroy@gmail.com \
    --cc=nabihestefan@google.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).