From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>,
Thomas Huth <thuth@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Klaus Jensen <k.jensen@samsung.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v3 1/2] hw/block/nvme: add dulbe support
Date: Thu, 22 Oct 2020 13:01:30 +0200 [thread overview]
Message-ID: <b9775e09-9a2e-3df1-afca-175fa55885e7@redhat.com> (raw)
In-Reply-To: <20201022022135.GA1663731@dhcp-10-100-145-180.wdc.com>
On 10/22/20 4:21 AM, Keith Busch wrote:
> On Thu, Oct 22, 2020 at 12:17:35AM +0200, Klaus Jensen wrote:
>> + for (int i = 1; i <= n->num_namespaces; i++) {
>
> You can call me old-school, but I don't think C should have allowed
> mixed declarations with code.
Since commit 7be41675f7c ("configure: Force the C standard to gnu99")
it is acceptable at the maintainer discretion. IOW if you don't want
declarations mixed with code, it is fine to ask contributors to not
do it in your subsystem.
Regards,
Phil.
next prev parent reply other threads:[~2020-10-22 11:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 22:17 [PATCH v3 0/2] hw/block/nvme: dulbe and dsm support Klaus Jensen
2020-10-21 22:17 ` [PATCH v3 1/2] hw/block/nvme: add dulbe support Klaus Jensen
2020-10-22 0:55 ` Keith Busch
2020-10-22 2:21 ` Keith Busch
2020-10-22 11:01 ` Philippe Mathieu-Daudé [this message]
2020-10-21 22:17 ` [PATCH v3 2/2] hw/block/nvme: add the dataset management command Klaus Jensen
2020-10-22 0:59 ` Keith Busch
2020-10-22 7:34 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9775e09-9a2e-3df1-afca-175fa55885e7@redhat.com \
--to=philmd@redhat.com \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).