From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Riku Voipio" <riku.voipio@iki.fi>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v2 5/6] hw/core: Restrict reset handlers API to system-mode
Date: Mon, 20 Jan 2020 06:27:18 +0100 [thread overview]
Message-ID: <b978ee01-0950-ea35-709b-0ce34cf677be@redhat.com> (raw)
In-Reply-To: <20200118140619.26333-6-philmd@redhat.com>
On 18/01/2020 15.06, Philippe Mathieu-Daudé wrote:
> The user-mode code does not use this API, restrict it
> to the system-mode.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/core/Makefile.objs | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
> index 0edd9e635d..2fea68ccf7 100644
> --- a/hw/core/Makefile.objs
> +++ b/hw/core/Makefile.objs
> @@ -1,6 +1,7 @@
> # core qdev-related obj files, also used by *-user:
> common-obj-y += qdev.o qdev-properties.o
> -common-obj-y += bus.o reset.o
> +common-obj-y += bus.o
> +common-obj-$(CONFIG_SOFTMMU) += reset.o
> common-obj-$(CONFIG_SOFTMMU) += qdev-fw.o
> common-obj-$(CONFIG_SOFTMMU) += fw-path-provider.o
> # irq.o needed for qdev GPIO handling:
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-01-20 5:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 14:06 [PATCH v2 0/6] buildsys: Build faster (mostly tools and linux-user) Philippe Mathieu-Daudé
2020-01-18 14:06 ` [PATCH v2 1/6] configure: Do not build libfdt if not required Philippe Mathieu-Daudé
2020-01-20 11:02 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 2/6] Makefile: Clarify all the codebase requires qom/ objects Philippe Mathieu-Daudé
2020-01-20 11:03 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 3/6] Makefile: Restrict system emulation and tools objects Philippe Mathieu-Daudé
2020-01-20 11:03 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 4/6] Makefile: Remove unhelpful comment Philippe Mathieu-Daudé
2020-01-20 11:04 ` Alex Bennée
2020-01-18 14:06 ` [PATCH v2 5/6] hw/core: Restrict reset handlers API to system-mode Philippe Mathieu-Daudé
2020-01-20 5:27 ` Thomas Huth [this message]
2020-01-20 11:07 ` Alex Bennée
2020-01-21 10:59 ` Philippe Mathieu-Daudé
2020-01-18 14:06 ` [PATCH v2 6/6] hw/core/Makefile: Group generic objects versus system-mode objects Philippe Mathieu-Daudé
2020-01-20 11:14 ` Alex Bennée
2020-01-18 14:22 ` [PATCH v2 0/6] buildsys: Build faster (mostly tools and linux-user) Philippe Mathieu-Daudé
2020-01-21 10:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b978ee01-0950-ea35-709b-0ce34cf677be@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).