From: John Snow <jsnow@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: jcody@redhat.com
Subject: Re: [Qemu-devel] [PATCH 01/10] blockjob: remove unnecessary check
Date: Fri, 7 Apr 2017 18:30:27 -0400 [thread overview]
Message-ID: <b98158c1-b3f0-be15-2b8b-9dae35ac4d7e@redhat.com> (raw)
In-Reply-To: <20170323173928.14439-2-pbonzini@redhat.com>
On 03/23/2017 01:39 PM, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockjob.c b/blockjob.c
> index 9b619f385..a9fb624 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -480,7 +480,7 @@ static bool block_job_should_pause(BlockJob *job)
>
> bool block_job_user_paused(BlockJob *job)
> {
> - return job ? job->user_paused : 0;
> + return job->user_paused;
> }
>
> void coroutine_fn block_job_pause_point(BlockJob *job)
>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2017-04-07 22:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:39 [Qemu-devel] [PATCH for-2.10 00/10] Preparation for block job mutex Paolo Bonzini
2017-03-23 17:39 ` [Qemu-devel] [PATCH 01/10] blockjob: remove unnecessary check Paolo Bonzini
2017-04-07 22:30 ` John Snow [this message]
2017-04-07 22:54 ` Philippe Mathieu-Daudé
2017-04-07 23:16 ` John Snow
2017-04-10 9:27 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 02/10] blockjob: remove iostatus_reset callback Paolo Bonzini
2017-04-07 23:12 ` John Snow
2017-04-08 0:18 ` Philippe Mathieu-Daudé
2017-04-10 9:27 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 03/10] blockjob: introduce block_job_fail Paolo Bonzini
2017-04-07 23:24 ` John Snow
2017-04-10 9:22 ` Stefan Hajnoczi
2017-04-11 4:00 ` Paolo Bonzini
2017-03-23 17:39 ` [Qemu-devel] [PATCH 04/10] blockjob: introduce block_job_pause/resume_all Paolo Bonzini
2017-04-07 23:37 ` John Snow
2017-04-10 9:26 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 05/10] blockjob: separate monitor and blockjob APIs Paolo Bonzini
2017-04-08 0:03 ` John Snow
2017-04-08 9:52 ` Paolo Bonzini
2017-04-10 16:05 ` John Snow
2017-04-11 4:57 ` Paolo Bonzini
2017-04-11 16:19 ` John Snow
2017-04-10 9:30 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 06/10] blockjob: move iostatus reset inside block_job_user_resume Paolo Bonzini
2017-04-08 0:28 ` John Snow
2017-04-10 9:33 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 07/10] blockjob: strengthen a bit test-blockjob-txn Paolo Bonzini
2017-04-08 0:37 ` John Snow
2017-04-10 9:35 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 08/10] blockjob: introduce block_job_cancel_async Paolo Bonzini
2017-04-08 1:13 ` John Snow
2017-04-08 9:54 ` Paolo Bonzini
2017-04-10 9:36 ` Stefan Hajnoczi
2017-03-23 17:39 ` [Qemu-devel] [PATCH 09/10] blockjob: reorganize block_job_completed_txn_abort Paolo Bonzini
2017-04-08 1:15 ` John Snow
2017-04-08 10:03 ` Paolo Bonzini
2017-04-10 9:44 ` Stefan Hajnoczi
2017-04-10 19:17 ` John Snow
2017-04-11 4:11 ` Paolo Bonzini
2017-03-23 17:39 ` [Qemu-devel] [PATCH 10/10] blockjob: use deferred_to_main_loop to indicate the coroutine has ended Paolo Bonzini
2017-04-08 1:32 ` John Snow
2017-04-08 9:56 ` Paolo Bonzini
2017-04-10 9:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98158c1-b3f0-be15-2b8b-9dae35ac4d7e@redhat.com \
--to=jsnow@redhat.com \
--cc=jcody@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).