From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, quintela@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
Cole Robinson <crobinso@redhat.com>
Subject: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
Date: Tue, 9 Apr 2019 19:19:57 -0400 [thread overview]
Message-ID: <b991a4d0e6c4253bc08b2794c6084be55fc72e1d.1554851834.git.crobinso@redhat.com> (raw)
The only caller that checks the error code is looking for != 0,
so returning false is incorrect.
Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 34bcad3807..a3dae4cf02 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp)
AioContext *aio_context;
if (migration_is_blocked(errp)) {
- return false;
+ return ret;
}
if (!replay_can_snapshot()) {
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Cole Robinson <crobinso@redhat.com>,
dgilbert@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers
Date: Tue, 9 Apr 2019 19:19:57 -0400 [thread overview]
Message-ID: <b991a4d0e6c4253bc08b2794c6084be55fc72e1d.1554851834.git.crobinso@redhat.com> (raw)
Message-ID: <20190409231957.cQnVFebE5h7PKHuKYhKbJVgCcVw2JtCUhp8I_O3YNU8@z> (raw)
The only caller that checks the error code is looking for != 0,
so returning false is incorrect.
Fixes: 5aaac467938 "migration: savevm: consult migration blockers"
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 34bcad3807..a3dae4cf02 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2544,7 +2544,7 @@ int save_snapshot(const char *name, Error **errp)
AioContext *aio_context;
if (migration_is_blocked(errp)) {
- return false;
+ return ret;
}
if (!replay_can_snapshot()) {
--
2.21.0
next reply other threads:[~2019-04-09 23:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 23:19 Cole Robinson [this message]
2019-04-09 23:19 ` [Qemu-devel] [PATCH] migration: savevm: fix error code with migration blockers Cole Robinson
2019-04-10 8:34 ` Dr. David Alan Gilbert
2019-04-10 8:34 ` Dr. David Alan Gilbert
2019-04-10 9:06 ` Juan Quintela
2019-04-10 9:06 ` Juan Quintela
2019-05-14 14:01 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b991a4d0e6c4253bc08b2794c6084be55fc72e1d.1554851834.git.crobinso@redhat.com \
--to=crobinso@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).