From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH 2/2] qemu/timer: Sanity check timer_list in timer_init_full()
Date: Sun, 9 Feb 2025 18:41:35 +0100 [thread overview]
Message-ID: <b9b0c5c1-1d1b-4c58-8540-4093356e2a4d@linaro.org> (raw)
In-Reply-To: <6b159be8-01e7-4dc7-9260-849432f1f4bf@tls.msk.ru>
On 9/2/25 10:41, Michael Tokarev wrote:
> 09.02.2025 12:37, Michael Tokarev wrote:
>> 25.01.2025 21:24, Philippe Mathieu-Daudé wrote:
>>
>>> - * You need not call an explicit deinit call. Simply make
>>> + * You need not call an explicit timer_deinit() call. Simply make
>>> * sure it is not on a list with timer_del.
>>
>> Reworded this as "You need not call timer_deinit() explicitly. Simply
>> make..."
>
> "You don't need to call timer_deinit() explicitly.", actually.
>
> This breaks quite a lot of CI tests: https://gitlab.com/mjt0k/qemu/-/
> pipelines/1662551717
Do sorry, I only tested on a specific config and missed all the
other errors :/
next prev parent reply other threads:[~2025-02-09 17:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-25 18:24 [PATCH 0/2] qemu/timer: Clarify QEMUTimer new/free API Philippe Mathieu-Daudé
2025-01-25 18:24 ` [PATCH 1/2] qemu/timer: Clarify timer_new*() must be freed with timer_free() Philippe Mathieu-Daudé
2025-02-06 10:39 ` Daniel P. Berrangé
2025-01-25 18:24 ` [PATCH 2/2] qemu/timer: Sanity check timer_list in timer_init_full() Philippe Mathieu-Daudé
2025-02-06 10:40 ` Daniel P. Berrangé
2025-02-09 9:37 ` Michael Tokarev
2025-02-09 9:41 ` Michael Tokarev
2025-02-09 17:41 ` Philippe Mathieu-Daudé [this message]
2025-02-04 21:44 ` [PATCH 0/2] qemu/timer: Clarify QEMUTimer new/free API Philippe Mathieu-Daudé
2025-02-06 9:44 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b0c5c1-1d1b-4c58-8540-4093356e2a4d@linaro.org \
--to=philmd@linaro.org \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).