From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E5ABC433DB for ; Tue, 9 Mar 2021 08:42:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 941966514C for ; Tue, 9 Mar 2021 08:42:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 941966514C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJXwm-0007jj-L6 for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 03:42:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJXwE-0007KZ-NJ for qemu-devel@nongnu.org; Tue, 09 Mar 2021 03:41:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:48234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJXwC-0001Xu-5M for qemu-devel@nongnu.org; Tue, 09 Mar 2021 03:41:58 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A2600ACC6; Tue, 9 Mar 2021 08:41:54 +0000 (UTC) Subject: Re: [RFC PATCH v2] meson: Only generate trace files for selected targets To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Stefan Hajnoczi References: <20210224213515.3331631-1-philmd@redhat.com> From: Claudio Fontana Message-ID: Date: Tue, 9 Mar 2021 09:41:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/8/21 6:48 PM, Philippe Mathieu-Daudé wrote: > On 3/8/21 5:46 PM, Stefan Hajnoczi wrote: >> On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote: >>> We don't need to generate trace files for targets we >>> are not building. Restrict the the ones selected. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> meson.build | 16 ++++++++-------- >>> 1 file changed, 8 insertions(+), 8 deletions(-) >>> >>> diff --git a/meson.build b/meson.build >>> index 05a67c20d93..8503aa1b628 100644 >>> --- a/meson.build >>> +++ b/meson.build >>> @@ -1826,16 +1826,16 @@ >>> trace_events_subdirs += [ >>> 'accel/tcg', >>> 'hw/core', >>> - 'target/arm', >>> - 'target/hppa', >>> - 'target/i386', >>> 'target/i386/kvm', >> >> Please add a comment explaining why an exception is needed here and the >> rest of the target directories are handled by the loop below when you >> send a non-RFC patch. > > Better would be a recursive function that adds the directory if > necessary. But I'm happy adding a simple comment =) > >> >> That will help people who add sub-directories in the future. > > Yes. Anyhow I expect this to clash with Claudio's work in progress > (which split target/ and add multiple subdirectories). > > np, just the tracedirs should be easy to solve; I personally don't see updating a simple list as difficult for the dev; does generating trace files for all require a lot of time? In any case, I agree that just recursing all directories in target/ looking for trace.h / traceevents files could be better. But how much time do we spare, compared with just generating all? Ciao, Claudio