qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Hervé Poussineau" <hpoussin@reactos.org>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, famz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function
Date: Thu, 28 Jun 2018 09:04:04 +0200	[thread overview]
Message-ID: <b9b923c7-4c7b-7ec5-327f-02053e79b800@redhat.com> (raw)
In-Reply-To: <d4216058-c627-f7f5-6502-851cca792dd1@reactos.org>

On 28/06/2018 07:58, Hervé Poussineau wrote:
> Le 27/06/2018 à 22:01, Mark Cave-Ayland a écrit :
>> On 13/06/18 10:47, Mark Cave-Ayland wrote:
>>
>>> Something else that came out of reviewing Laurent's q800 patchset:
>>> after my
>>> SPARC cleanups last year, MIPS Jazz is the last remaining user of the
>>> legacy
>>> esp_init() function.
>>>
>>> Patch 1 switches mips_jazz_init() over to create the ESP device directly
>>> via qdev. Please note that I do not have any MIPS jazz images and so
>>> this
>>> is compile-tested only (although passes "make check") and needs an
>>> ACK from
>>> someone (Hervé?).
>>>
>>> Now that the last user of esp_init() is gone, patch 2 removes the legacy
>>> function and its associated header.
>>>
>>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>>
>>>
>>> Mark Cave-Ayland (2):
>>>    hw/mips/jazz: create ESP device directly via qdev
>>>    esp: remove legacy esp_init() function
>>>
>>>   hw/mips/mips_jazz.c   | 19 ++++++++++++++++---
>>>   hw/scsi/esp.c         | 30 ------------------------------
>>>   include/hw/scsi/esp.h |  5 -----
>>>   3 files changed, 16 insertions(+), 38 deletions(-)
>>
>> Ping? Is anyone able to test the MIPS jazz board with these patches at
>> all?
> 
> Tested-by: Hervé Poussineau <hpoussin@reactos.org>
> 
> 

Queued, thanks.

Paolo

      reply	other threads:[~2018-06-28  7:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13  9:47 [Qemu-devel] [PATCH 0/2] scsi: remove legacy esp_init() function Mark Cave-Ayland
2018-06-13  9:47 ` [Qemu-devel] [PATCH 1/2] hw/mips/jazz: create ESP device directly via qdev Mark Cave-Ayland
2018-06-13 10:06   ` Paolo Bonzini
2018-06-13 10:36     ` Mark Cave-Ayland
2018-06-13 11:19       ` Paolo Bonzini
2018-06-13 13:06         ` Mark Cave-Ayland
2018-06-13 14:12           ` Paolo Bonzini
2018-06-13  9:47 ` [Qemu-devel] [PATCH 2/2] esp: remove legacy esp_init() function Mark Cave-Ayland
2018-06-27 20:01 ` [Qemu-devel] [PATCH 0/2] scsi: " Mark Cave-Ayland
2018-06-28  5:58   ` Hervé Poussineau
2018-06-28  7:04     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9b923c7-4c7b-7ec5-327f-02053e79b800@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).