From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
qemu-arm@nongnu.org, linux@roeck-us.net, robh@kernel.org
Subject: [Qemu-devel] [PATCH v2 1/5] arm: boot: Adjust indentation of FIXUP comments
Date: Thu, 29 Oct 2015 22:34:56 -0700 [thread overview]
Message-ID: <b9b9bb8f1c307c1ef8a3f26ff1f34fabb34b332e.1446182614.git.crosthwaite.peter@gmail.com> (raw)
In-Reply-To: <cover.1446182614.git.crosthwaite.peter@gmail.com>
In-Reply-To: <cover.1446182614.git.crosthwaite.peter@gmail.com>
These comments start immediately after the current longest name in the
list. Tab them out to the next tab stop to give a little breathing room
and prepare for FIXUP_BOARD_SETUP which will require more indent.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---
Changed since v1:
s/comment/comments in commit message.
hw/arm/boot.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index bef451b..2a151e2 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -28,14 +28,14 @@
#define KERNEL64_LOAD_ADDR 0x00080000
typedef enum {
- FIXUP_NONE = 0, /* do nothing */
- FIXUP_TERMINATOR, /* end of insns */
- FIXUP_BOARDID, /* overwrite with board ID number */
- FIXUP_ARGPTR, /* overwrite with pointer to kernel args */
- FIXUP_ENTRYPOINT, /* overwrite with kernel entry point */
- FIXUP_GIC_CPU_IF, /* overwrite with GIC CPU interface address */
- FIXUP_BOOTREG, /* overwrite with boot register address */
- FIXUP_DSB, /* overwrite with correct DSB insn for cpu */
+ FIXUP_NONE = 0, /* do nothing */
+ FIXUP_TERMINATOR, /* end of insns */
+ FIXUP_BOARDID, /* overwrite with board ID number */
+ FIXUP_ARGPTR, /* overwrite with pointer to kernel args */
+ FIXUP_ENTRYPOINT, /* overwrite with kernel entry point */
+ FIXUP_GIC_CPU_IF, /* overwrite with GIC CPU interface address */
+ FIXUP_BOOTREG, /* overwrite with boot register address */
+ FIXUP_DSB, /* overwrite with correct DSB insn for cpu */
FIXUP_MAX,
} FixupType;
--
1.9.1
next prev parent reply other threads:[~2015-10-30 5:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 5:34 [Qemu-devel] [PATCH v2 0/5] ARM: Machine specific boot blobs Peter Crosthwaite
2015-10-30 5:34 ` Peter Crosthwaite [this message]
2015-10-30 5:34 ` [Qemu-devel] [PATCH v2 2/5] arm: boot: Add board specific setup code API Peter Crosthwaite
2015-10-30 5:34 ` [Qemu-devel] [PATCH v2 3/5] arm: xilinx_zynq: Add linux pre-boot Peter Crosthwaite
2015-11-05 0:41 ` Alistair Francis
2015-10-30 5:34 ` [Qemu-devel] [PATCH v2 4/5] arm: boot: Add secure_board_setup flag Peter Crosthwaite
2015-10-30 20:49 ` Peter Maydell
2015-10-30 20:59 ` Peter Crosthwaite
2015-10-30 21:14 ` Peter Maydell
2015-10-30 21:24 ` Peter Crosthwaite
2015-10-30 22:04 ` Peter Maydell
2015-10-30 22:07 ` Peter Crosthwaite
2015-10-31 3:40 ` Peter Crosthwaite
2015-10-31 10:35 ` Peter Maydell
2015-10-30 5:35 ` [Qemu-devel] [PATCH v2 5/5] arm: highbank: Implement PSCI and dummy monitor Peter Crosthwaite
2015-10-30 21:10 ` Peter Maydell
2015-10-30 21:32 ` Peter Crosthwaite
2015-10-30 22:09 ` Peter Maydell
2015-10-30 20:44 ` [Qemu-devel] [PATCH v2 0/5] ARM: Machine specific boot blobs Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b9bb8f1c307c1ef8a3f26ff1f34fabb34b332e.1446182614.git.crosthwaite.peter@gmail.com \
--to=crosthwaitepeter@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=linux@roeck-us.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).