From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buwza-0004BZ-UZ for qemu-devel@nongnu.org; Fri, 14 Oct 2016 03:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buwzW-00053r-Mv for qemu-devel@nongnu.org; Fri, 14 Oct 2016 03:33:21 -0400 References: <1476388410-4187-1-git-send-email-lvivier@redhat.com> From: Laurent Vivier Message-ID: Date: Fri, 14 Oct 2016 09:33:15 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tests: add mac99 and g3beige in boot-serial-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 13/10/2016 22:26, Thomas Huth wrote: > On 13.10.2016 21:53, Laurent Vivier wrote: >> g3beige (pmac_oldworld) and mac99 (pmac_newworld) are missing in >> boot-serial-test. >> >> Perhaps because serial output of OpenBIOS is only enabled with >> '-nographic' > > IIRC clearly, I've left them out because they are basically already > tested with the prom-env test. I was a little bit afraid that the > testing time would become too long, but since this test is quite fast, > and it makes sense to check whether the serial output is working, too, I > think it's also OK if you add them here. > > Two thoughts though: > > 1) I think you do *not* need the "-nographic" here, because the test is > using the "-serial" parameter to get the output of the serial console. Yes, you're right, and as it was not an oversight, just forget this patch... Thanks, Laurent