Re: [PATCH 4/6] target/i386: Add feature dependencies for AVX10

[Paolo Bonzini <pbonzini@redhat.com>]

On 10/28/24 03:45, Tao Su wrote:
> Since the highest supported vector length for a processor implies that
> all lesser vector lengths are also supported, add the dependencies of
> the supported vector lengths. If all vector lengths aren't supported,
> clear AVX10 enable bit as well.
> 
> Note that the order of AVX10 related dependencies should be kept as:
>          CPUID_24_0_EBX_AVX10_128     -> CPUID_24_0_EBX_AVX10_256,
>          CPUID_24_0_EBX_AVX10_256     -> CPUID_24_0_EBX_AVX10_512,
>          CPUID_24_0_EBX_AVX10_VL_MASK -> CPUID_7_1_EDX_AVX10,

I think you need to add a set of dependencies so that avx10 cannot be 
set, unless all the older AVX features that it's composed of are 
available.  From the manual these are

AVX512F, AVX512CD, AVX512VW, AVX512DQ, AVX512_VBMI, AVX512_IFMA, 
AVX512_VNNI, AVX512_BF16, AVX512_VPOPCNTDQ, AVX512_VBMI2, VAES, GFNI,
VPCLMULQDQ, AVX512_BITALG, AVX512_FP16.

Otherwise, the changes look good.

Thanks,

Paolo