From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: Re: [RFC PATCH] tcg: Restrict qemu_ld2 and qemu_st2 opcodes to 32-bit hosts
Date: Thu, 9 Oct 2025 10:38:40 -0700 [thread overview]
Message-ID: <b9e34640-43bf-4345-9718-f319ff185c1a@linaro.org> (raw)
In-Reply-To: <f745f163-6bad-47ad-a1c0-4be96b604266@linaro.org>
On 10/9/25 10:23, Philippe Mathieu-Daudé wrote:
> On 21/8/25 22:27, Richard Henderson wrote:
>> On 8/20/25 23:49, Philippe Mathieu-Daudé wrote:
>>> qemu_ld2 and qemu_st2 opcodes are band-aid for 32-bit hosts
>>> and can't be reached on 64-bit ones. See in commit 3bedb9d3e28
>>> ("tcg: Convert qemu_ld{2} to TCGOutOpLoad{2}") and 86fe5c2597c
>>> ("tcg: Convert qemu_st{2} to TCGOutOpLdSt{2}") their constraint
>>> is C_NotImplemented.
>>
>> Not true: ld2/st2 are also used for 128-bit load store.
>>
>> See: aarch64, x86_64, loongarch64, ppc64, s390x.
>
> OK. Hmm I guess I need to add a __attribute__((unused)) check like
> you did in commit f408df587a0 ("tcg: Convert brcond2_i32 to
> TCGOutOpBrcond2") to outop_qemu_ld2/st2 then.
Why? Please expand on the error you're seeing.
r~
next prev parent reply other threads:[~2025-10-09 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 13:49 [RFC PATCH] tcg: Restrict qemu_ld2 and qemu_st2 opcodes to 32-bit hosts Philippe Mathieu-Daudé
2025-08-21 20:27 ` Richard Henderson
2025-10-09 17:23 ` Philippe Mathieu-Daudé
2025-10-09 17:38 ` Richard Henderson [this message]
2025-10-09 19:13 ` Philippe Mathieu-Daudé
2025-10-09 17:43 ` Philippe Mathieu-Daudé
2025-10-09 19:08 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e34640-43bf-4345-9718-f319ff185c1a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).