From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: amir.gonnen@neuroblade.ai
Subject: Re: [PATCH 7/7] target/nios2: Rewrite interrupt handling
Date: Sun, 27 Feb 2022 23:05:18 +0100 [thread overview]
Message-ID: <b9e75e23-d3e7-503b-87c3-4e8031e19f76@gmail.com> (raw)
In-Reply-To: <20220227182125.21809-8-richard.henderson@linaro.org>
On 27/2/22 19:21, Richard Henderson wrote:
> Drop irq_pending boolean.
> Drop helper_check_interrupts.
> Move checks for irq disabled into nios2_cpu_exec_interrupt.
> End the TB on writes to ienable, just like to status.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/nios2/cpu.h | 1 -
> target/nios2/helper.h | 1 -
> target/nios2/cpu.c | 10 ++++------
> target/nios2/op_helper.c | 19 -------------------
> target/nios2/translate.c | 14 +++++---------
> 5 files changed, 9 insertions(+), 36 deletions(-)
LGTM but better have another review...
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2022-02-27 22:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 18:21 [PATCH 0/7] target/nios2: Rewrite interrupt handling Richard Henderson
2022-02-27 18:21 ` [PATCH 1/7] target/nios2: Remove mmu_read_debug Richard Henderson
2022-03-02 12:44 ` Peter Maydell
2022-02-27 18:21 ` [PATCH 2/7] target/nios2: Replace MMU_LOG with tracepoints Richard Henderson
2022-02-27 22:01 ` Philippe Mathieu-Daudé
2022-03-02 12:48 ` Peter Maydell
2022-02-27 18:21 ` [PATCH 3/7] target/nios2: Only build mmu.c for system mode Richard Henderson
2022-02-27 22:01 ` Philippe Mathieu-Daudé
2022-03-02 12:49 ` Peter Maydell
2022-02-27 18:21 ` [PATCH 4/7] target/nios2: Hoist R_ZERO check in rdctl Richard Henderson
2022-02-27 22:02 ` Philippe Mathieu-Daudé
2022-03-02 12:50 ` Peter Maydell
2022-02-27 18:21 ` [PATCH 5/7] target/nios2: Split mmu_write Richard Henderson
2022-03-02 12:57 ` Peter Maydell
2022-02-27 18:21 ` [PATCH 6/7] target/nios2: Special case ipending in rdctl and wrctl Richard Henderson
2022-02-27 22:06 ` Philippe Mathieu-Daudé
2022-03-02 13:00 ` Peter Maydell
2022-02-27 18:21 ` [PATCH 7/7] target/nios2: Rewrite interrupt handling Richard Henderson
2022-02-27 22:05 ` Philippe Mathieu-Daudé [this message]
2022-03-02 13:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e75e23-d3e7-503b-87c3-4e8031e19f76@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=amir.gonnen@neuroblade.ai \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).