From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org,
d-tatianin@yandex-team.ru,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 3/8] chardev: .chr_open(): drop be_opened parameter
Date: Thu, 4 Dec 2025 16:34:40 +0300 [thread overview]
Message-ID: <b9f48b03-c1e7-4d5e-ae3c-4e5cb265c963@yandex-team.ru> (raw)
In-Reply-To: <CAMxuvaxA3FQO0PXpk8jJhP-nqeXADKPf-1orOkee9ES0_CHNKw@mail.gmail.com>
On 01.12.25 15:57, Marc-André Lureau wrote:
> {
> ChardevSpiceChannel *spicevmc = backend->u.spicevmc.data;
> @@ -277,19 +275,17 @@ static void spice_vmc_chr_open(Chardev *chr,
> return;
> }
>
> - *be_opened = false;
> #if SPICE_SERVER_VERSION < 0x000e02
> /* Spice < 0.14.2 doesn't explicitly open smartcard chardev */
> if (strcmp(type, "smartcard") == 0) {
> - *be_opened = true;
> + chr_open(chr, type);
> + qemu_chr_be_event(chr, CHR_EVENT_OPENED);
> }
> #endi
>
>
> Can you add a preliminary patch to drop support for spice < 0.15 ?
> According to repology:
> debian_13: 0.15.2
> fedora_42: 0.15.1
> opensuse_leap_15_4: 0.15.0
> ubuntu_22_04: 0.15.0
Will do. Thanks for reviewing!
--
Best regards,
Vladimir
next prev parent reply other threads:[~2025-12-04 13:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 13:43 [PATCH for-11.0 0/8] chardev: cleanup Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 1/8] chardev: ChardevClass: consistent naming for handlers Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 2/8] chardev: consistent naming for ChardevClass handlers implementations Vladimir Sementsov-Ogievskiy
2025-11-29 14:07 ` Philippe Mathieu-Daudé
2025-11-29 13:43 ` [PATCH 3/8] chardev: .chr_open(): drop be_opened parameter Vladimir Sementsov-Ogievskiy
2025-12-01 12:57 ` Marc-André Lureau
2025-12-04 13:34 ` Vladimir Sementsov-Ogievskiy [this message]
2025-11-29 13:43 ` [PATCH 4/8] chardev: .chr_open(): add boolean return value Vladimir Sementsov-Ogievskiy
2025-11-29 14:08 ` Philippe Mathieu-Daudé
2025-11-29 13:43 ` [PATCH 5/8] chardev/char-pty: store pty_name into PtyChardev state Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 6/8] chardev: introduce .chr_get_pty_name() handler Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 7/8] chardev: rework filename handling Vladimir Sementsov-Ogievskiy
2025-11-29 13:43 ` [PATCH 8/8] chardev/char: qemu_char_open(): add return value Vladimir Sementsov-Ogievskiy
2025-11-29 14:17 ` Philippe Mathieu-Daudé
2025-12-01 13:00 ` [PATCH for-11.0 0/8] chardev: cleanup Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f48b03-c1e7-4d5e-ae3c-4e5cb265c963@yandex-team.ru \
--to=vsementsov@yandex-team.ru \
--cc=alex.bennee@linaro.org \
--cc=d-tatianin@yandex-team.ru \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).