From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD2ACC77B75 for ; Fri, 21 Apr 2023 04:05:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppi0o-00009V-NU; Fri, 21 Apr 2023 00:04:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppi0n-00009D-EQ for qemu-devel@nongnu.org; Fri, 21 Apr 2023 00:04:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppi0l-00041V-Cb for qemu-devel@nongnu.org; Fri, 21 Apr 2023 00:04:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682049877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vMzNTPrUJS5JMZ6SEkPKIcJnwhAMSTH/bLapn1qPrl0=; b=NcjRlAP1OfGlsslybTReoKkgH+Gg6DdZX0CNeqR3+rliEQl831WKo2wHv+oVffVhlzv6rI FCJ9gbPLvRmUcKJbpl/clCvoXfd+p3BrmgV6M8AW0qDNShdp+Tiyauilvx6D+fPmdfEKyA VbE+7YykYpbZTl8KaY/0G0cSFSM8amE= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644--bbhv0P7PKGq3y73uUM1pw-1; Fri, 21 Apr 2023 00:04:35 -0400 X-MC-Unique: -bbhv0P7PKGq3y73uUM1pw-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3ef388e1fd5so9501531cf.0 for ; Thu, 20 Apr 2023 21:04:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682049874; x=1684641874; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vMzNTPrUJS5JMZ6SEkPKIcJnwhAMSTH/bLapn1qPrl0=; b=EOFB6x9sQ5ZdIGu4pkOuGTOtnu6Rl3m/ICGUXLe4o288fETSmoAzx0gpszPj8hcRm3 uLNsp//jCCvKWGkFwLFgXJaGY/LAJ/E4c6TCbSXp+J9UKUWfdjwJzxAm+ePg7iHEDra3 WzndwE/eHS4V8rMXqr1CT3nIDSSy/jQ4HSUVhjV7RNF5r6LKswFeFwpyOO8qiIJkv6As XRdU3vCYbGjnAVCWtl7PUKcn9R1uq6uMe1cJGWINbf5mrQe5C/fLdzweT4LPyYvSMHdi gdMyh9qrUIPFqxTll+QB8y+0RrU3rTtjI2sFwNzCyLj3KKRMbG+NjTDCp8WR0q9f8umP 7zsQ== X-Gm-Message-State: AAQBX9dK/FzJuiJaNGohnF88jEknZykUsCFYM3tXEgueJYpZod4q6RUK oMIgynPOSCHD5jTb++WWmi1jWkQiZTZNwVt7ZlykrwkP2XQd6M8A7ht9C4VFH1L40iBKJ7x4CZ7 DNpUYirorI46IRnU= X-Received: by 2002:ac8:7e89:0:b0:3ef:390d:1b4 with SMTP id w9-20020ac87e89000000b003ef390d01b4mr6016582qtj.9.1682049874029; Thu, 20 Apr 2023 21:04:34 -0700 (PDT) X-Google-Smtp-Source: AKy350bN87Ik97/cOBJpK0aFcnktojCkNIIRpkgbsq4evfmJdfXFb3wkKN+sDcfqatIRWU0ocwIe6Q== X-Received: by 2002:ac8:7e89:0:b0:3ef:390d:1b4 with SMTP id w9-20020ac87e89000000b003ef390d01b4mr6016556qtj.9.1682049873745; Thu, 20 Apr 2023 21:04:33 -0700 (PDT) Received: from ?IPV6:2601:18d:8a00:cfa:780e:7574:2b4c:7be5? ([2601:18d:8a00:cfa:780e:7574:2b4c:7be5]) by smtp.gmail.com with ESMTPSA id b10-20020a05622a020a00b003e65228ef54sm1015739qtx.86.2023.04.20.21.04.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 21:04:33 -0700 (PDT) Message-ID: Date: Fri, 21 Apr 2023 00:04:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 1/6] tests/requirements.txt: bump up avocado-framework version to 101.0 Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= , John Snow Cc: Jan Richter , qemu-devel@nongnu.org, Peter Maydell , Bastian Koppelmann , Markus Armbruster , Beraldo Leal , Thomas Huth , Stefan Hajnoczi , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Radoslaw Biernacki , Leif Lindholm , Paolo Bonzini , Wainer dos Santos Moschetta , qemu-arm@nongnu.org, Kautuk Consul , Hariharan T S References: <20230417134321.3627231-1-alex.bennee@linaro.org> <20230417134321.3627231-2-alex.bennee@linaro.org> <87pm82e74d.fsf@linaro.org> <74be23e6-015b-cb1d-967e-65fc32347553@linaro.org> From: Cleber Rosa In-Reply-To: <74be23e6-015b-cb1d-967e-65fc32347553@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.669, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/20/23 05:18, Philippe Mathieu-Daudé wrote: > On 17/4/23 19:44, Alex Bennée wrote: >> >> John Snow writes: >> >>> On Mon, Apr 17, 2023 at 9:43 AM Alex Bennée >>> wrote: >>>> >>>> From: Kautuk Consul >>>> >>>> Avocado version 101.0 has a fix to re-compute the checksum >>>> of an asset file if the algorithm used in the *-CHECKSUM >>>> file isn't the same as the one being passed to it by the >>>> avocado user (i.e. the avocado_qemu python module). >>>> In the earlier avocado versions this fix wasn't there due >>>> to which if the checksum wouldn't match the earlier >>>> checksum (calculated by a different algorithm), the avocado >>>> code would start downloading a fresh image from the internet >>>> URL thus making the test-cases take longer to execute. >>>> >>>> Bump up the avocado-framework version to 101.0. >>>> >>>> Signed-off-by: Kautuk Consul >>>> Tested-by: Hariharan T S >>>> Message-Id: <20230327115030.3418323-2-kconsul@linux.vnet.ibm.com> >>>> Message-Id: <20230330101141.30199-10-alex.bennee@linaro.org> >>>> >>>> --- >>>> v2 >>>>    - limit --max-parallel-tasks $(JOBS_OPTION:-j%=%) >>>> --- >>>>   tests/Makefile.include | 18 +++++++++++------- >>>>   tests/requirements.txt |  2 +- >>>>   2 files changed, 12 insertions(+), 8 deletions(-) >>>> >>>> diff --git a/tests/Makefile.include b/tests/Makefile.include >>>> index 9422ddaece..a4de0ad5a2 100644 >>>> --- a/tests/Makefile.include >>>> +++ b/tests/Makefile.include >>>> @@ -138,14 +138,18 @@ get-vm-image-fedora-31-%: check-venv >>>>   # download all vm images, according to defined targets >>>>   get-vm-images: check-venv $(patsubst %,get-vm-image-fedora-31-%, >>>> $(FEDORA_31_DOWNLOAD)) >>>> >>>> +JOBS_OPTION=$(lastword -j1 $(filter-out -j, $(filter >>>> -j%,$(MAKEFLAGS)))) >>>> + >>>>   check-avocado: check-venv $(TESTS_RESULTS_DIR) get-vm-images >>>> -       $(call quiet-command, \ >>>> -            $(TESTS_PYTHON) -m avocado \ >>>> -            --show=$(AVOCADO_SHOW) run >>>> --job-results-dir=$(TESTS_RESULTS_DIR) \ >>>> -            $(if $(AVOCADO_TAGS),, --filter-by-tags-include-empty \ >>>> -                       --filter-by-tags-include-empty-key) \ >>>> -            $(AVOCADO_CMDLINE_TAGS) \ >>>> -            $(if $(GITLAB_CI),,--failfast) $(AVOCADO_TESTS), \ >>>> +       $(call quiet-command, \ >>>> +            $(TESTS_PYTHON) -m >>>> avocado                                                 \ >>>> +            --show=$(AVOCADO_SHOW) run >>>> --job-results-dir=$(TESTS_RESULTS_DIR)  \ >>>> +            $(if $(AVOCADO_TAGS),, \ >>>> + --filter-by-tags-include-empty                          \ >>>> + --filter-by-tags-include-empty-key)                     \ >>>> +               --max-parallel-tasks >>>> $(JOBS_OPTION:-j%=%)                       \ >>>> + $(AVOCADO_CMDLINE_TAGS) \ >>>> +            $(if $(GITLAB_CI),,--failfast) >>>> $(AVOCADO_TESTS),                   \ >>>>               "AVOCADO", "tests/avocado") >>>> >>>>   check-acceptance-deprecated-warning: >>>> diff --git a/tests/requirements.txt b/tests/requirements.txt >>>> index 0ba561b6bd..a6f73da681 100644 >>>> --- a/tests/requirements.txt >>>> +++ b/tests/requirements.txt >>>> @@ -2,5 +2,5 @@ >>>>   # in the tests/venv Python virtual environment. For more info, >>>>   # refer to: https://pip.pypa.io/en/stable/user_guide/#id1 >>>>   # Note that qemu.git/python/ is always implicitly installed. >>>> -avocado-framework==88.1 >>>> +avocado-framework==101.0 >>>>   pycdlib==1.11.0 >>>> -- >>>> 2.39.2 >>>> >>> >>> I thought there were test failures that prohibited us from bumping the >>> Avocado-Framework version. Did those get rectified recently? > > No, still not working on Darwin. At this point I'm thinking at sending > a patch clarifying testing QEMU with Avocado is not supported on Darwin. > Hi Phil, Do you mean with or without this version bump? Even though it was somewhat recently[1] that another level of Darwin compatibility was added to Avocado, where a good part of Avocado's selftests[2] were enabled in OS X, Avocado 101.0 should not be that far behind. I honestly believe people testing and reporting successful execution of the Avocado tests under Darwin with latest Avocado. Hopefully my memory is not playing tricks on me, but I'll attempt to verify that. Cheers, - Cleber. [1] - https://github.com/avocado-framework/avocado/pull/5622 [2] - https://github.com/avocado-framework/avocado/actions/runs/4417285317/jobs/7742772932?pr=5622#step:10:11 >> I'm not seeing any with your patch applied. > > Are you using running the Cirrus-CI jobs? >