From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH for-8.1 1/3] target/arm/ptw.c: Add comments to S1Translate struct fields
Date: Thu, 13 Jul 2023 18:37:44 +0100 [thread overview]
Message-ID: <ba359b58-c854-3608-c736-90dac2eb6356@linaro.org> (raw)
In-Reply-To: <20230710152130.3928330-2-peter.maydell@linaro.org>
On 7/10/23 16:21, Peter Maydell wrote:
> Add comments to the in_* fields in the S1Translate struct
> that explain what they're doing.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> I figured some of this out when writing commit fcc0b0418fff,
> and then I found I'd forgotten it all when I was trying
> to fix this new bug. So this time I'm writing this down :-)
> ---
> target/arm/ptw.c | 40 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-07-13 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 15:21 [PATCH for-8.1 0/3] target/arm: Fix ptw bugs introduced by FEAT_RME changes Peter Maydell
2023-07-10 15:21 ` [PATCH for-8.1 1/3] target/arm/ptw.c: Add comments to S1Translate struct fields Peter Maydell
2023-07-13 17:37 ` Richard Henderson [this message]
2023-07-10 15:21 ` [PATCH for-8.1 2/3] target/arm: Fix S1_ptw_translate() debug path Peter Maydell
2023-07-10 16:46 ` Peter Maydell
2023-07-11 11:05 ` Jean-Philippe Brucker
2023-07-13 18:28 ` Richard Henderson
2023-07-10 15:21 ` [PATCH for-8.1 3/3] target/arm/ptw.c: Account for FEAT_RME when applying {N}SW, SA bits Peter Maydell
2023-07-13 18:31 ` [PATCH for-8.1 3/3] target/arm/ptw.c: Account for FEAT_RME when applying {N}SW,SA bits Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba359b58-c854-3608-c736-90dac2eb6356@linaro.org \
--to=richard.henderson@linaro.org \
--cc=jean-philippe@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).