From: "Cédric Le Goater" <clg@redhat.com>
To: Shivaprasad G Bhat <sbhat@linux.ibm.com>,
harshpb@linux.ibm.com, npiggin@gmail.com
Cc: danielhb413@gmail.com, david@gibson.dropbear.id.au,
alex.williamson@redhat.com, qemu-ppc@nongnu.org,
zhenzhong.duan@intel.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] vfio: container: Fix missing allocation of VFIOSpaprContainer
Date: Fri, 21 Jun 2024 10:49:05 +0200 [thread overview]
Message-ID: <ba376f81-2175-4e3d-bda0-4b08b2ae5158@redhat.com> (raw)
In-Reply-To: <cef472a4-da2c-449e-8f76-0b3e9105e194@linux.ibm.com>
On 6/21/24 10:17 AM, Shivaprasad G Bhat wrote:
> Hi Cédric,
>
> On 6/20/24 6:37 PM, Cédric Le Goater wrote:
>> Shivaprasad,
>>
>> On 5/9/24 9:14 PM, Shivaprasad G Bhat wrote:
>>> The commit 6ad359ec29 "(vfio/spapr: Move prereg_listener into
>>> spapr container)" began to use the newly introduced VFIOSpaprContainer
>>> structure.
>>>
>>> After several refactors, today the container_of(container,
>>> VFIOSpaprContainer, ABC) is used when VFIOSpaprContainer is actually
>>> not allocated. On PPC64 systems, this dereference is leading to corruption
>>> showing up as glibc malloc assertion during guest start when using vfio.
>>>
>>> Patch adds the missing allocation while also making the structure movement
>>> to vfio common header file.
>>>
>>> Fixes: 6ad359ec29 "(vfio/spapr: Move prereg_listener into spapr container)"
>>> Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
>>
>> Could you please give vfio-9.1 a try ? Thanks,
>>
> Yes. This is working fine for ppc64.
Could you please describe the host/guest OS, hypervisor, processor
and adapter ?
Thanks,
C.
next prev parent reply other threads:[~2024-06-21 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 19:14 [PATCH] vfio: container: Fix missing allocation of VFIOSpaprContainer Shivaprasad G Bhat
2024-05-10 2:34 ` Duan, Zhenzhong
2024-05-13 12:23 ` Cédric Le Goater
2024-05-22 16:15 ` Shivaprasad G Bhat
2024-05-27 13:35 ` Cédric Le Goater
2024-06-20 13:07 ` Cédric Le Goater
2024-06-21 8:17 ` Shivaprasad G Bhat
2024-06-21 8:49 ` Cédric Le Goater [this message]
2024-06-21 14:47 ` Shivaprasad G Bhat
2024-06-21 15:10 ` Cédric Le Goater
2024-06-26 3:56 ` Shivaprasad G Bhat
2024-06-28 10:37 ` Cédric Le Goater
2024-07-01 16:49 ` Shivaprasad G Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba376f81-2175-4e3d-bda0-4b08b2ae5158@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sbhat@linux.ibm.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).