From: Auger Eric <eric.auger@redhat.com>
To: Vijay Kilari <vijay.kilari@gmail.com>
Cc: eric.auger.pro@gmail.com,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
shannon.zhao@linaro.org,
Christoffer Dall <christoffer.dall@linaro.org>,
drjones@redhat.com, "Kumar, Vijaya" <Vijaya.Kumar@cavium.com>,
peterx@redhat.com, Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [RFC 2/4] hw/intc/arm_gicv3_kvm: Rename KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS
Date: Fri, 27 Jan 2017 08:44:36 +0100 [thread overview]
Message-ID: <ba3db103-9b6f-880d-aeea-d3194a1d34f1@redhat.com> (raw)
In-Reply-To: <CALicx6uLp5SapC5PiDRB6OdaVWXVNYUCORAQ7EsPJ-KNNF5cTw@mail.gmail.com>
Hi Vijaya,
On 27/01/2017 08:02, Vijay Kilari wrote:
> Hi Eric,
>
> On Thu, Jan 26, 2017 at 2:49 PM, Eric Auger <eric.auger@redhat.com> wrote:
>> Rename KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS into KVM_DEV_ARM_VGIC_CPU_SYSREGS
>> as exposed in the kernel user API and pulled by update-linux-headers.sh.
>
> I will fix it in my next qemu patch series.
> I have updated kernel to use KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS in
> latest kernel patch
> version v11. I so you can drop this patch.
Sure I saw the change in your v11.
Thanks
Eric
>
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>>
>> ---
>>
>> KVM_DEV_ARM_VGIC_CPU_SYSREGS may be fixed at kernel level instead
>> ---
>> hw/intc/arm_gicv3_kvm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
>> index 267c2d6..d8ecbc3 100644
>> --- a/hw/intc/arm_gicv3_kvm.c
>> +++ b/hw/intc/arm_gicv3_kvm.c
>> @@ -108,7 +108,7 @@ static inline void kvm_gicr_access(GICv3State *s, int offset, int cpu,
>> static inline void kvm_gicc_access(GICv3State *s, uint64_t reg, int cpu,
>> uint64_t *val, bool write)
>> {
>> - kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS,
>> + kvm_device_access(s->dev_fd, KVM_DEV_ARM_VGIC_CPU_SYSREGS,
>> KVM_VGIC_ATTR(reg, s->cpu[cpu].gicr_typer),
>> val, write);
>> }
>> --
>> 2.5.5
>>
next prev parent reply other threads:[~2017-01-27 7:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 9:19 [Qemu-devel] [RFC 0/4] vITS save/restore Eric Auger
2017-01-26 9:19 ` [Qemu-devel] [RFC 1/4] linux-headers: Partial update for " Eric Auger
2017-01-26 9:19 ` [Qemu-devel] [RFC 2/4] hw/intc/arm_gicv3_kvm: Rename KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS Eric Auger
2017-01-27 7:02 ` Vijay Kilari
2017-01-27 7:44 ` Auger Eric [this message]
2017-01-26 9:19 ` [Qemu-devel] [RFC 3/4] hw/intc/arm_gicv3_its: Implement state save/restore Eric Auger
2017-01-27 7:17 ` Vijay Kilari
2017-01-27 7:43 ` Auger Eric
2017-01-30 9:15 ` Juan Quintela
2017-01-30 10:45 ` Auger Eric
2017-01-30 16:40 ` Juan Quintela
2017-01-26 9:19 ` [Qemu-devel] [RFC 4/4] hw/intc/arm_gicv3_its: Allow save/restore Eric Auger
2017-01-26 10:06 ` Dr. David Alan Gilbert
2017-01-26 13:30 ` Auger Eric
2017-02-03 9:55 ` Peter Xu
2017-02-03 9:57 ` Dr. David Alan Gilbert
2017-02-03 11:38 ` Peter Xu
2017-02-07 14:36 ` [Qemu-devel] [RFC 0/4] vITS save/restore Peter Maydell
2017-02-10 9:07 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba3db103-9b6f-880d-aeea-d3194a1d34f1@redhat.com \
--to=eric.auger@redhat.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=christoffer.dall@linaro.org \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shannon.zhao@linaro.org \
--cc=vijay.kilari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).