From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>,
qemu-trivial@nongnu.org, Hannes Reinecke <hare@suse.com>,
qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] hw/scsi/megasas: Remove pointless parenthesis
Date: Sun, 14 Feb 2021 00:13:49 +0100 [thread overview]
Message-ID: <ba6f06a4-d90e-176e-60b7-351be1619595@vivier.eu> (raw)
In-Reply-To: <20201011195001.3219730-1-f4bug@amsat.org>
Le 11/10/2020 à 21:50, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/scsi/megasas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index e24c12d7eed..d57402c9b09 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -2384,8 +2384,8 @@ static void megasas_scsi_realize(PCIDevice *dev, Error **errp)
> if (!s->sas_addr) {
> s->sas_addr = ((NAA_LOCALLY_ASSIGNED_ID << 24) |
> IEEE_COMPANY_LOCALLY_ASSIGNED) << 36;
> - s->sas_addr |= (pci_dev_bus_num(dev) << 16);
> - s->sas_addr |= (PCI_SLOT(dev->devfn) << 8);
> + s->sas_addr |= pci_dev_bus_num(dev) << 16;
> + s->sas_addr |= PCI_SLOT(dev->devfn) << 8;
> s->sas_addr |= PCI_FUNC(dev->devfn);
> }
> if (!s->hba_serial) {
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2021-02-13 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 19:50 [PATCH] hw/scsi/megasas: Remove pointless parenthesis Philippe Mathieu-Daudé
2021-02-13 22:56 ` Laurent Vivier
2021-02-13 23:13 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba6f06a4-d90e-176e-60b7-351be1619595@vivier.eu \
--to=laurent@vivier.eu \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=hare@suse.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).