* [PATCH] hw/scsi/megasas: Remove pointless parenthesis
@ 2020-10-11 19:50 Philippe Mathieu-Daudé
2021-02-13 22:56 ` Laurent Vivier
2021-02-13 23:13 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-11 19:50 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Hannes Reinecke, qemu-block, qemu-trivial,
Philippe Mathieu-Daudé, Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/scsi/megasas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index e24c12d7eed..d57402c9b09 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -2384,8 +2384,8 @@ static void megasas_scsi_realize(PCIDevice *dev, Error **errp)
if (!s->sas_addr) {
s->sas_addr = ((NAA_LOCALLY_ASSIGNED_ID << 24) |
IEEE_COMPANY_LOCALLY_ASSIGNED) << 36;
- s->sas_addr |= (pci_dev_bus_num(dev) << 16);
- s->sas_addr |= (PCI_SLOT(dev->devfn) << 8);
+ s->sas_addr |= pci_dev_bus_num(dev) << 16;
+ s->sas_addr |= PCI_SLOT(dev->devfn) << 8;
s->sas_addr |= PCI_FUNC(dev->devfn);
}
if (!s->hba_serial) {
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/scsi/megasas: Remove pointless parenthesis
2020-10-11 19:50 [PATCH] hw/scsi/megasas: Remove pointless parenthesis Philippe Mathieu-Daudé
@ 2021-02-13 22:56 ` Laurent Vivier
2021-02-13 23:13 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-02-13 22:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Fam Zheng, qemu-trivial, Hannes Reinecke, qemu-block,
Paolo Bonzini
Le 11/10/2020 à 21:50, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/scsi/megasas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index e24c12d7eed..d57402c9b09 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -2384,8 +2384,8 @@ static void megasas_scsi_realize(PCIDevice *dev, Error **errp)
> if (!s->sas_addr) {
> s->sas_addr = ((NAA_LOCALLY_ASSIGNED_ID << 24) |
> IEEE_COMPANY_LOCALLY_ASSIGNED) << 36;
> - s->sas_addr |= (pci_dev_bus_num(dev) << 16);
> - s->sas_addr |= (PCI_SLOT(dev->devfn) << 8);
> + s->sas_addr |= pci_dev_bus_num(dev) << 16;
> + s->sas_addr |= PCI_SLOT(dev->devfn) << 8;
> s->sas_addr |= PCI_FUNC(dev->devfn);
> }
> if (!s->hba_serial) {
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/scsi/megasas: Remove pointless parenthesis
2020-10-11 19:50 [PATCH] hw/scsi/megasas: Remove pointless parenthesis Philippe Mathieu-Daudé
2021-02-13 22:56 ` Laurent Vivier
@ 2021-02-13 23:13 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-02-13 23:13 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Fam Zheng, qemu-trivial, Hannes Reinecke, qemu-block,
Paolo Bonzini
Le 11/10/2020 à 21:50, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/scsi/megasas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index e24c12d7eed..d57402c9b09 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -2384,8 +2384,8 @@ static void megasas_scsi_realize(PCIDevice *dev, Error **errp)
> if (!s->sas_addr) {
> s->sas_addr = ((NAA_LOCALLY_ASSIGNED_ID << 24) |
> IEEE_COMPANY_LOCALLY_ASSIGNED) << 36;
> - s->sas_addr |= (pci_dev_bus_num(dev) << 16);
> - s->sas_addr |= (PCI_SLOT(dev->devfn) << 8);
> + s->sas_addr |= pci_dev_bus_num(dev) << 16;
> + s->sas_addr |= PCI_SLOT(dev->devfn) << 8;
> s->sas_addr |= PCI_FUNC(dev->devfn);
> }
> if (!s->hba_serial) {
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-13 23:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-11 19:50 [PATCH] hw/scsi/megasas: Remove pointless parenthesis Philippe Mathieu-Daudé
2021-02-13 22:56 ` Laurent Vivier
2021-02-13 23:13 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).