From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64F6FC64EC7 for ; Sat, 25 Feb 2023 10:12:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVrX4-0001uw-VA; Sat, 25 Feb 2023 05:11:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVrX2-0001tG-Ne for qemu-devel@nongnu.org; Sat, 25 Feb 2023 05:11:56 -0500 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVrWz-0002Cm-VF for qemu-devel@nongnu.org; Sat, 25 Feb 2023 05:11:56 -0500 Received: by mail-wr1-x42c.google.com with SMTP id bw19so1559277wrb.13 for ; Sat, 25 Feb 2023 02:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3MCfv4LzIXiF0tFCznb7EnVVaPdFKemSsILAkfg0NBk=; b=dpLolZHqImlfvW0+JrL5gppFBYBGlmTK8jP5zrj4ZMx2PW4Lw9X2/VZhb4kVKyNubl 0T+E4NBBry+WBfmiPeFy7qOarLAnzInVle24+cOXJrrmohs78rjFNsD6ikFxy2gcsEQa 8AREGDNQ7dtRA/lgWtq8TbUXcYS9nf8pM5PljQ/on2a/FsgRAoJp9fyr5MC0WNrUqaf1 JsI/kzHiXiSEswHfD81gtJgThpzjplE70tMLGBspZo1kNO8O7JHPcpWUd7LYWmF+slwC s7P0CnioGSf2PSlYneIXeFY4p6P90umfpOAkSkWMmedpZsnmpc68fTJZZOsHO/nmEBBJ OLoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3MCfv4LzIXiF0tFCznb7EnVVaPdFKemSsILAkfg0NBk=; b=RKeziC9ocYOaI1DLcNwcIEgVbT/SW8xkCTmJTWkrm1lOGRpVIXP8UEE1QYkPsMGlkp j41yWcUvfiQVo+MHZDn9VLTZcKmrrmnZe8oJ5h5rfm75wLGrmkd+CcNQ7ufAeWXos8Qf 7N8HscbRvBZzgQrrOTnilIiebg8aLBtZt5A4I40rWxIVxn4TMLi1vYjRxfTZBAnafzsz 3p3dMJ4bbiVJeXMKVtoLM1dgRePX1v92JKDyrrDd1nrGFFHdRUD+MRrpo/E9WoXJr8FE Qlmao9e3VweQH2/Ppol1/bYI8rwMOCijVdXNfpotPODKxolvqYogJPKge7168bybDKRN 6ZOw== X-Gm-Message-State: AO0yUKXKV0Or+ckNWcDCj6NUeBWgHhBgihQHbfpY4oKdx+yeMAM3dIaN 5H924EIJ1F5Ua+j0NuvfHN9qng== X-Google-Smtp-Source: AK7set9hvJ8UdWyzWpXgETMwk2ggvUct7FyTOyujuSTskLRUc/WwF3Zu5DbfqWSs84d9FstMMr64ZA== X-Received: by 2002:a5d:58d9:0:b0:2c5:5fb0:b215 with SMTP id o25-20020a5d58d9000000b002c55fb0b215mr15585116wrf.30.1677319912459; Sat, 25 Feb 2023 02:11:52 -0800 (PST) Received: from [192.168.136.175] (120.red-95-127-35.staticip.rima-tde.net. [95.127.35.120]) by smtp.gmail.com with ESMTPSA id t14-20020adfe44e000000b002c5503a8d21sm1356744wrm.70.2023.02.25.02.11.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Feb 2023 02:11:52 -0800 (PST) Message-ID: Date: Sat, 25 Feb 2023 11:11:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 00/76] tcg: Drop tcg_temp_free from translators Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, jcmvbkbc@gmail.com, kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp, gaosong@loongson.cn, jiaxun.yang@flygoat.com, tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com, edgar.iglesias@gmail.com References: <20230225091427.1817156-1-richard.henderson@linaro.org> <6b17a5c3-143a-42ca-ec87-dd8108aac9e9@linaro.org> In-Reply-To: <6b17a5c3-143a-42ca-ec87-dd8108aac9e9@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 25/2/23 11:10, Philippe Mathieu-Daudé wrote: > On 25/2/23 10:13, Richard Henderson wrote: >> Based-on: 20230225085945.1798188-1-richard.henderson@linaro.org >> ("[PATCH v3 00/30] tcg: Simplify temporary usage") >> >> In the above patch set, we changed the lifetime of the temps >> allocated by the guest translators, and eliminated their reuse, >> so that we have the best chance of reducing their strength. >> >> That we don't reuse them means that we gain nothing by freeing them. >> Therefore, drop all mention of tcg_temp_free from target/. >> >> This may be the most negative diffstat I've ever produced.  :-) > >>   94 files changed, 471 insertions(+), 7143 deletions(-) > > 7143 + 2 = 7145 by removing tcg_const_ptr(): > > -- >8 -- > diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h > index 43ce4bfa7d..64b88268cd 100644 > --- a/include/tcg/tcg.h > +++ b/include/tcg/tcg.h > @@ -1020,6 +1020,4 @@ TCGv_vec tcg_constant_vec_matching(TCGv_vec match, > unsigned vece, int64_t val); >  #if UINTPTR_MAX == UINT32_MAX > -# define tcg_const_ptr(x)        ((TCGv_ptr)tcg_const_i32((intptr_t)(x))) >  # define tcg_constant_ptr(x) ((TCGv_ptr)tcg_constant_i32((intptr_t)(x))) >  #else > -# define tcg_const_ptr(x)        ((TCGv_ptr)tcg_const_i64((intptr_t)(x))) >  # define tcg_constant_ptr(x) ((TCGv_ptr)tcg_constant_i64((intptr_t)(x))) > diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c > index 5bf80b22d7..ce40fac557 100644 > --- a/target/arm/translate-sve.c > +++ b/target/arm/translate-sve.c > @@ -4210,3 +4210,3 @@ void gen_sve_ldr(DisasContext *s, TCGv_ptr base, > int vofs, >          TCGLabel *loop = gen_new_label(); > -        TCGv_ptr tp, i = tcg_const_ptr(0); > +        TCGv_ptr tp, i = tcg_constant_ptr(NULL); Scratch that, I missed i is modified: tcg_gen_addi_ptr(i, i, 8);