From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Roque Arcudia Hernandez <roqueh@google.com>
Subject: Re: [PATCH 2/3] tests/qtest: Use qtest_system_reset() instead of open-coded versions
Date: Mon, 18 Nov 2024 11:29:14 +0100 [thread overview]
Message-ID: <ba8a9ce8-c941-4d41-8c8c-7ea936d42e80@linaro.org> (raw)
In-Reply-To: <20241115165041.1148095-3-peter.maydell@linaro.org>
On 15/11/24 16:50, Peter Maydell wrote:
> Use the qtest_system_reset() function in various tests that were
> previously open-coding the system-reset. Note that in several
> cases this fixes a bug where the test did not wait for the RESET
> QMP event before continuing.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I can split this patch up if people prefer, but for test code
> and given the size of the diffstat it didn't seem worthwhile.
> ---
> tests/qtest/bios-tables-test.c | 4 ++--
> tests/qtest/boot-order-test.c | 7 +------
> tests/qtest/hd-geo-test.c | 9 +--------
> tests/qtest/q35-test.c | 12 ++----------
> tests/qtest/qos-test.c | 3 +--
> tests/qtest/stm32l4x5_gpio-test.c | 10 +---------
> tests/qtest/stm32l4x5_syscfg-test.c | 12 ++----------
> 7 files changed, 10 insertions(+), 47 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-11-18 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 16:50 [PATCH 0/3] qtest: Provide and use function for doing system reset Peter Maydell
2024-11-15 16:50 ` [PATCH 1/3] tests/qtest: Add qtest_system_reset() utility function Peter Maydell
2024-11-18 10:30 ` Philippe Mathieu-Daudé
2024-11-15 16:50 ` [PATCH 2/3] tests/qtest: Use qtest_system_reset() instead of open-coded versions Peter Maydell
2024-11-18 10:29 ` Philippe Mathieu-Daudé [this message]
2024-11-15 16:50 ` [PATCH 3/3] tests/qtest: Use qtest_system_reset_nowait() where appropriate Peter Maydell
2024-11-22 13:00 ` Fabiano Rosas
2024-11-22 13:07 ` [PATCH 0/3] qtest: Provide and use function for doing system reset Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba8a9ce8-c941-4d41-8c8c-7ea936d42e80@linaro.org \
--to=philmd@linaro.org \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=roqueh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).