From: WANG Xuerui <i.qemu@xen0n.name>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts
Date: Tue, 21 Sep 2021 14:02:45 +0800 [thread overview]
Message-ID: <baa4bcf7-9e4f-1745-5957-6d715a14f711@xen0n.name> (raw)
In-Reply-To: <de7efdfe-24ae-015c-015d-50acc245df1c@linaro.org>
Hi Richard,
On 9/21/21 01:23, Richard Henderson wrote:
> On 9/20/21 1:04 AM, WANG Xuerui wrote:
>> Signed-off-by: WANG Xuerui <git@xen0n.name>
>> ---
>> configure | 4 +++-
>> meson.build | 4 +++-
>> 2 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 1043ccce4f..f1bc85e71b 100755
>> --- a/configure
>> +++ b/configure
>> @@ -659,6 +659,8 @@ elif check_define __arm__ ; then
>> cpu="arm"
>> elif check_define __aarch64__ ; then
>> cpu="aarch64"
>> +elif check_define __loongarch64 ; then
>> + cpu="loongarch64"
>> else
>> cpu=$(uname -m)
>> fi
>> @@ -667,7 +669,7 @@ ARCH=
>> # Normalise host CPU name and set ARCH.
>> # Note that this case should only have supported host CPUs, not
>> guests.
>> case "$cpu" in
>> - ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64)
>> + ppc|ppc64|s390x|sparc64|x32|riscv32|riscv64|loongarch64)
>> ;;
>> ppc64le)
>> ARCH="ppc64"
>> diff --git a/meson.build b/meson.build
>> index 2711cbb789..fb3befead5 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -57,7 +57,7 @@ python = import('python').find_installation()
>> supported_oses = ['windows', 'freebsd', 'netbsd', 'openbsd',
>> 'darwin', 'sunos', 'linux']
>> supported_cpus = ['ppc', 'ppc64', 's390x', 'riscv32', 'riscv64',
>> 'x86', 'x86_64',
>> - 'arm', 'aarch64', 'mips', 'mips64', 'sparc', 'sparc64']
>> + 'arm', 'aarch64', 'loongarch64', 'mips', 'mips64', 'sparc',
>> 'sparc64']
>> cpu = host_machine.cpu_family()
>> targetos = host_machine.system()
>> @@ -269,6 +269,8 @@ if not get_option('tcg').disabled()
>> tcg_arch = 's390'
>> elif config_host['ARCH'] in ['x86_64', 'x32']
>> tcg_arch = 'i386'
>> + elif config_host['ARCH'] == 'loongarch64'
>> + tcg_arch = 'loongarch'
>
> Be consistent with loongarch or loongarch64 everywhere.
>
> If there's no loongarch32, and never will be, then there's probably no
> point in keeping the '64' suffix.
The loongarch32 tuple will most certainly come into existence some time
in the future, but probably bare-metal-only and without a Linux port
AFAIK. That's a point the Loongson people and I didn't communicate well,
apologizes for that. (While we're at it, the reserved "loongarchx32"
which is x32/n32-like, most likely will never exist.)
So should I drop the explicit probing for __loongarch64, instead just
probe for __loongarch__ and later #error out the non-__loongarch64 cases
individually?
>
>
> r~
next prev parent reply other threads:[~2021-09-21 6:03 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 8:04 [PATCH 00/30] 64-bit LoongArch port of QEMU TCG WANG Xuerui
2021-09-20 8:04 ` [PATCH 01/30] elf: Add machine type value for LoongArch WANG Xuerui
2021-09-20 8:04 ` [PATCH 02/30] MAINTAINERS: Add tcg/loongarch entry with myself as maintainer WANG Xuerui
2021-09-20 14:50 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 03/30] tcg/loongarch: Add the tcg-target.h file WANG Xuerui
2021-09-20 14:23 ` Richard Henderson
2021-09-20 16:20 ` WANG Xuerui
2021-09-20 16:25 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 04/30] tcg/loongarch: Add generated instruction opcodes and encoding helpers WANG Xuerui
2021-09-20 15:55 ` Richard Henderson
2021-09-20 16:24 ` WANG Xuerui
2021-09-21 9:58 ` Philippe Mathieu-Daudé
2021-09-21 11:40 ` WANG Xuerui
2021-09-20 8:04 ` [PATCH 05/30] tcg/loongarch: Add register names, allocation order and input/output sets WANG Xuerui
2021-09-20 15:57 ` Richard Henderson
2021-09-20 16:27 ` WANG Xuerui
2021-09-20 8:04 ` [PATCH 06/30] tcg/loongarch: Define the operand constraints WANG Xuerui
2021-09-20 14:28 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 07/30] tcg/loongarch: Implement necessary relocation operations WANG Xuerui
2021-09-20 14:36 ` Richard Henderson
2021-09-20 17:15 ` WANG Xuerui
2021-09-20 8:04 ` [PATCH 08/30] tcg/loongarch: Implement the memory barrier op WANG Xuerui
2021-09-20 8:04 ` [PATCH 09/30] tcg/loongarch: Implement tcg_out_mov and tcg_out_movi WANG Xuerui
2021-09-20 14:47 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 10/30] tcg/loongarch: Implement goto_ptr WANG Xuerui
2021-09-20 14:49 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 11/30] tcg/loongarch: Implement sign-/zero-extension ops WANG Xuerui
2021-09-20 14:50 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 12/30] tcg/loongarch: Implement not/and/or/xor/nor/andc/orc ops WANG Xuerui
2021-09-20 14:54 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 13/30] tcg/loongarch: Implement deposit/extract ops WANG Xuerui
2021-09-20 14:55 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 14/30] tcg/loongarch: Implement bswap32_i32/bswap64_i64 WANG Xuerui
2021-09-20 15:11 ` Richard Henderson
2021-09-20 18:20 ` Richard Henderson
2021-09-21 6:37 ` WANG Xuerui
2021-09-20 8:04 ` [PATCH 15/30] tcg/loongarch: Implement clz/ctz ops WANG Xuerui
2021-09-20 16:10 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 16/30] tcg/loongarch: Implement shl/shr/sar/rotl/rotr ops WANG Xuerui
2021-09-20 16:13 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 17/30] tcg/loongarch: Implement neg/add/sub ops WANG Xuerui
2021-09-20 16:16 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 18/30] tcg/loongarch: Implement mul/mulsh/muluh/div/divu/rem/remu ops WANG Xuerui
2021-09-20 16:16 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 19/30] tcg/loongarch: Implement br/brcond ops WANG Xuerui
2021-09-20 16:20 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 20/30] tcg/loongarch: Implement setcond ops WANG Xuerui
2021-09-20 16:24 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 21/30] tcg/loongarch: Implement tcg_out_call WANG Xuerui
2021-09-20 16:31 ` Richard Henderson
2021-09-20 16:35 ` Richard Henderson
2021-09-21 6:42 ` WANG Xuerui
2021-09-20 8:04 ` [PATCH 22/30] tcg/loongarch: Implement simple load/store ops WANG Xuerui
2021-09-20 16:35 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 23/30] tcg/loongarch: Add softmmu load/store helpers, implement qemu_ld/qemu_st ops WANG Xuerui
2021-09-20 17:10 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 24/30] tcg/loongarch: Implement tcg_target_qemu_prologue WANG Xuerui
2021-09-20 17:15 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 25/30] tcg/loongarch: Implement exit_tb/goto_tb WANG Xuerui
2021-09-20 17:16 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 26/30] tcg/loongarch: Implement tcg_target_init WANG Xuerui
2021-09-20 17:19 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 27/30] tcg/loongarch: Register the JIT WANG Xuerui
2021-09-20 17:21 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts WANG Xuerui
2021-09-20 17:23 ` Richard Henderson
2021-09-21 6:02 ` WANG Xuerui [this message]
2021-09-21 6:59 ` Philippe Mathieu-Daudé
2021-09-21 7:24 ` WANG Xuerui
2021-09-21 13:30 ` Richard Henderson
2021-09-21 14:07 ` WANG Xuerui
2021-09-21 14:10 ` WANG Xuerui
2021-09-21 14:42 ` Peter Maydell
2021-09-21 15:59 ` Richard Henderson
2021-09-21 16:09 ` WANG Xuerui
2021-09-21 17:26 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 29/30] linux-user: Add host dependency for 64-bit LoongArch WANG Xuerui
2021-09-20 17:26 ` Richard Henderson
2021-09-20 8:04 ` [PATCH 30/30] accel/tcg/user-exec: Implement CPU-specific signal handler for LoongArch hosts WANG Xuerui
2021-09-20 17:31 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baa4bcf7-9e4f-1745-5957-6d715a14f711@xen0n.name \
--to=i.qemu@xen0n.name \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).