From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH for-5.2 02/19] m25p80: Add support for mx25l25635f
Date: Fri, 7 Aug 2020 07:59:43 +0200 [thread overview]
Message-ID: <baad9663-5df1-9a90-5cc7-44fda7a18cda@kaod.org> (raw)
In-Reply-To: <CACPK8XddhjsdTF2tiiuFoDZ9L+LqOSJLydE-YUAqkbGs4OvquA@mail.gmail.com>
On 8/7/20 12:55 AM, Joel Stanley wrote:
> On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater <clg@kaod.org> wrote:
>>
>> The mx25l25635f is an extenstion of the mx25l25635e. It includes QPI
>> support, 4-Byte Address Command Set and faster transfers. See this
>> document for more details :
>>
>> https://www.macronix.com/Lists/ApplicationNote/Attachments/1892/AN0200V1_MGRT_MX25L25635E_25735E%20to%20MX25L25635F_25735F.pdf
>>
>> Both devices have the same 3bytes JEDEC ID: 0xc22019. They can be
>> distinguished with the QPIID command which is only available on
>> mx25l25635f. The mx25l25635f also has a longer JEDEC ID that we can
>> use for the model.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>
> Reviewed-by: Joel Stanley <joel@jms.id.au>
>
> We don't have support for this one in upstream Linux.
It's detected by testing the 4BYTE operation capability in the SFDP table
in mx25l25635_post_bfpt_fixups()
The only system I have access to is a SuperMicro P9 Boston but I can not
upload a new kernel. However, the FW reports :
BMC flash ID: 0xc21920c2
jedec_id: 0xc21920c2
flash type: MX25L25635F
ReadClk=0x32, WriteClk=0x85, EraseClk=0x85
[smcfw_spi] cpuclk: 198000000 MHz, RefCLK: 24000000 MHz, AXI-AHB ratio: 2:1
platform_flash: MX25L25635F (32768 Kbytes)
> It's the one
> that Alexander tried to get merged by renaming the mysterious
> mx66l51235l.
Yes. That one behaves a bit more like the mx25l25635e.
Difficult to find a detection pattern. A model for SFDP would help.
C.
>
>> ---
>> hw/block/m25p80.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
>> index 605ff55c6756..1696ab1f7821 100644
>> --- a/hw/block/m25p80.c
>> +++ b/hw/block/m25p80.c
>> @@ -218,6 +218,7 @@ static const FlashPartInfo known_devices[] = {
>> { INFO("mx25l12805d", 0xc22018, 0, 64 << 10, 256, 0) },
>> { INFO("mx25l12855e", 0xc22618, 0, 64 << 10, 256, 0) },
>> { INFO6("mx25l25635e", 0xc22019, 0xc22019, 64 << 10, 512, 0) },
>> + { INFO("mx25l25635f", 0xc22019, 0xc200, 64 << 10, 512, 0) },
>> { INFO("mx25l25655e", 0xc22619, 0, 64 << 10, 512, 0) },
>> { INFO("mx66u51235f", 0xc2253a, 0, 64 << 10, 1024, ER_4K | ER_32K) },
>> { INFO("mx66u1g45g", 0xc2253b, 0, 64 << 10, 2048, ER_4K | ER_32K) },
>> --
>> 2.25.4
>>
next prev parent reply other threads:[~2020-08-07 6:01 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:20 [PATCH for-5.2 00/19] aspeed: mostly cleanups and some extensions Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 01/19] m25p80: Return the JEDEC ID twice for mx25l25635e Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 02/19] m25p80: Add support for mx25l25635f Cédric Le Goater
2020-08-06 22:55 ` Joel Stanley
2020-08-07 5:59 ` Cédric Le Goater [this message]
2020-08-06 13:20 ` [PATCH for-5.2 03/19] m25p80: Add support for n25q512ax3 Cédric Le Goater
2020-08-06 22:56 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 04/19] aspeed/scu: Fix valid access size on AST2400 Cédric Le Goater
2020-08-06 13:32 ` Philippe Mathieu-Daudé
2020-08-06 13:49 ` Cédric Le Goater
2020-08-06 14:08 ` Philippe Mathieu-Daudé
2020-08-06 22:57 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 05/19] hw/arm/aspeed: Add board model for Supermicro X11 BMC Cédric Le Goater
2020-08-06 23:23 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 06/19] aspeed/smc: Fix MemoryRegionOps definition Cédric Le Goater
2020-08-06 23:24 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 07/19] aspeed/smc: Fix max_slaves of the legacy SMC device Cédric Le Goater
2020-08-06 23:24 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 08/19] aspeed/sdhci: Fix reset sequence Cédric Le Goater
2020-08-06 23:42 ` Joel Stanley
2020-08-07 6:04 ` Cédric Le Goater
2020-08-10 17:16 ` Cédric Le Goater
2020-08-10 23:20 ` Joel Stanley
2020-08-11 7:05 ` Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 09/19] ftgmac100: Fix registers that can be read Cédric Le Goater
2020-08-06 13:33 ` Philippe Mathieu-Daudé
2020-08-06 23:44 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 10/19] ftgmac100: Fix interrupt status "Packet transmitted on ethernet" Cédric Le Goater
2020-08-06 23:47 ` Joel Stanley
2020-08-07 6:06 ` Cédric Le Goater
2020-08-06 13:20 ` [PATCH for-5.2 11/19] ftgmac100: Fix interrupt status "Packet moved to RX FIFO" Cédric Le Goater
2020-08-06 23:48 ` Joel Stanley
2020-08-06 13:20 ` [PATCH for-5.2 12/19] ftgmac100: Change interrupt status when a DMA error occurs Cédric Le Goater
2020-08-06 23:51 ` Joel Stanley
2020-08-07 6:19 ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 13/19] ftgmac100: Check for invalid len and address before doing a DMA transfer Cédric Le Goater
2020-08-06 23:51 ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 14/19] ftgmac100: Fix integer overflow in ftgmac100_do_tx() Cédric Le Goater
2020-08-06 23:57 ` Joel Stanley
2020-08-10 13:43 ` Mauro Matteo Cascella
2020-08-10 17:14 ` Cédric Le Goater
2020-08-11 12:20 ` Mauro Matteo Cascella
2020-08-11 12:39 ` Peter Maydell
2020-08-18 14:54 ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 15/19] ftgmac100: Improve software reset Cédric Le Goater
2020-08-06 13:40 ` Philippe Mathieu-Daudé
2020-08-07 0:03 ` Joel Stanley
2020-08-07 6:21 ` Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 16/19] aspeed/sdmc: Perform memory training Cédric Le Goater
2020-08-06 13:38 ` Philippe Mathieu-Daudé
2020-08-07 0:10 ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 17/19] aspeed/sdmc: Allow writes to unprotected registers Cédric Le Goater
2020-08-06 13:21 ` [PATCH for-5.2 18/19] aspeed/sdmc: Simplify calculation of RAM bits Cédric Le Goater
2020-08-07 0:11 ` Joel Stanley
2020-08-06 13:21 ` [PATCH for-5.2 19/19] aspeed/smc: Open AHB window of the second chip of the AST2600 FMC controller Cédric Le Goater
2020-08-07 0:12 ` Joel Stanley
2020-08-06 13:24 ` [PATCH for-5.2 00/19] aspeed: mostly cleanups and some extensions Cédric Le Goater
2020-08-07 9:14 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baad9663-5df1-9a90-5cc7-44fda7a18cda@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).