From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v2] qapi: enable use of g_autoptr with QAPI types
Date: Thu, 23 Jul 2020 10:56:57 -0500 [thread overview]
Message-ID: <bab1824b-fb83-7d06-074e-9c8144c8ce59@redhat.com> (raw)
In-Reply-To: <20200723153845.2934357-1-berrange@redhat.com>
On 7/23/20 10:38 AM, Daniel P. Berrangé wrote:
> Currently QAPI generates a type and function for free'ing it:
>
> typedef struct QCryptoBlockCreateOptions QCryptoBlockCreateOptions;
> void qapi_free_QCryptoBlockCreateOptions(QCryptoBlockCreateOptions *obj);
>
>
> The above code example now becomes
>
> g_autoptr(QCryptoBlockCreateOptions) opts = NULL;
>
> opts = g_new0(QCryptoBlockCreateOptions, 1);
>
> ....do stuff with opts...
>
> Note, if the local pointer needs to live beyond the scope holding the
> variable, then g_steal_pointer can be used. This is useful to return the
> pointer to the caller in the success codepath, while letting it be freed
> in all error codepaths.
>
> return g_steal_pointer(&opts);
>
> The crypto/block.h header needs updating to avoid symbol clash now that
> the g_autoptr support is a standard QAPI feature.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-07-23 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 15:38 [PATCH v2] qapi: enable use of g_autoptr with QAPI types Daniel P. Berrangé
2020-07-23 15:56 ` Eric Blake [this message]
2020-07-24 7:58 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bab1824b-fb83-7d06-074e-9c8144c8ce59@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).