From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, ehabkost@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
crosa@redhat.com, den@openvz.org
Subject: Re: [PATCH v8 4/7] scripts: add block-coroutine-wrapper.py
Date: Thu, 24 Sep 2020 12:20:47 -0400 [thread overview]
Message-ID: <bab922d6-a38b-6580-b7a9-6e74da1751d3@redhat.com> (raw)
In-Reply-To: <73781605-a817-c627-fea9-183caf84c4b6@redhat.com>
On 9/23/20 8:00 PM, Eric Blake wrote:
>
>
> There's enough grammar fixes, and the fact that John is working on
> python cleanups, to make me wonder if we need a v9, or if I should just
> stage it where it is with any other cleanups as followups. But I'm
> liking the reduced maintenance burden once it is in, and don't want to
> drag it out to the point that it needs more rebasing as other things
> land first.
Don't worry about it too much. I'd rather we have a helpful script
sooner than later than worry about Python style purity before I have the
CI mechanisms for it fully established.
(I eyeballed it and it looks like you already use type hints, so I have
faith it won't need much cleanup.)
Thanks!
--js
next prev parent reply other threads:[~2020-09-24 16:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 16:44 [PATCH v8 0/7] coroutines: generate wrapper code Vladimir Sementsov-Ogievskiy
2020-09-15 16:44 ` [PATCH v8 1/7] block: return error-code from bdrv_invalidate_cache Vladimir Sementsov-Ogievskiy
2020-09-24 8:26 ` Philippe Mathieu-Daudé
2020-09-24 11:19 ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 2/7] block/io: refactor coroutine wrappers Vladimir Sementsov-Ogievskiy
2020-09-23 19:41 ` Eric Blake
2020-09-24 8:27 ` Philippe Mathieu-Daudé
2020-09-24 11:24 ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 3/7] block: declare some coroutine functions in block/coroutines.h Vladimir Sementsov-Ogievskiy
2020-09-23 21:47 ` Eric Blake
2020-09-24 8:34 ` Philippe Mathieu-Daudé
2020-09-24 11:25 ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 4/7] scripts: add block-coroutine-wrapper.py Vladimir Sementsov-Ogievskiy
2020-09-15 20:02 ` Vladimir Sementsov-Ogievskiy
2020-09-24 0:00 ` Eric Blake
2020-09-24 1:20 ` Eric Blake
2020-09-24 7:08 ` Vladimir Sementsov-Ogievskiy
2020-09-24 6:59 ` Vladimir Sementsov-Ogievskiy
2020-09-24 16:20 ` John Snow [this message]
2020-09-24 0:18 ` Eric Blake
2020-09-24 7:08 ` Vladimir Sementsov-Ogievskiy
2020-09-24 11:40 ` Stefan Hajnoczi
2020-09-24 17:56 ` Eric Blake
2020-09-24 18:52 ` Vladimir Sementsov-Ogievskiy
2020-09-15 16:44 ` [PATCH v8 5/7] block: generate coroutine-wrapper code Vladimir Sementsov-Ogievskiy
2020-09-24 12:14 ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 6/7] block: drop bdrv_prwv Vladimir Sementsov-Ogievskiy
2020-09-24 8:31 ` Philippe Mathieu-Daudé
2020-09-24 12:15 ` Stefan Hajnoczi
2020-09-15 16:44 ` [PATCH v8 7/7] block/io: refactor save/load vmstate Vladimir Sementsov-Ogievskiy
2020-09-23 20:10 ` Eric Blake
2020-09-24 7:20 ` Vladimir Sementsov-Ogievskiy
2020-09-24 12:16 ` Stefan Hajnoczi
2020-09-24 12:16 ` [PATCH v8 0/7] coroutines: generate wrapper code Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bab922d6-a38b-6580-b7a9-6e74da1751d3@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).