From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 4/8] nbd: Minimal structured read for server
Date: Mon, 16 Oct 2017 10:41:25 -0500 [thread overview]
Message-ID: <bac1f011-2aa6-5b02-707b-bbb12b9a07fd@redhat.com> (raw)
In-Reply-To: <5ec13265-60d3-aeb6-641b-9aaebfbe498e@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
On 10/16/2017 07:18 AM, Eric Blake wrote:
> On 10/16/2017 04:49 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 15.10.2017 04:01, Eric Blake wrote:
>>> From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>
>>> Minimal implementation of structured read: one structured reply chunk,
>>> no segmentation.
>>> Minimal structured error implementation: no text message.
>>> Support DF flag, but just ignore it, as there is no segmentation any
>>> way.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>>
>
>>> +
>>> + case NBD_OPT_STRUCTURED_REPLY:
>>> + if (client->structured_reply) {
>>> + ret = nbd_negotiate_send_rep_err(
>>> + client->ioc, NBD_REP_ERR_INVALID, option, errp,
>>> + "structured reply already negotiated");
>>
>> You were going to send a patch to spec for this..
>
> Still am; it's on my queue for tasks to do today. :)
https://lists.debian.org/nbd/2017/nbd-201710/msg00013.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-10-16 15:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-15 1:01 [Qemu-devel] [PATCH v4 0/8] nbd mimimal structured read Eric Blake
2017-10-15 1:01 ` [Qemu-devel] [PATCH v4 1/8] nbd: Include error names in trace messages Eric Blake
2017-10-16 8:30 ` Vladimir Sementsov-Ogievskiy
2017-10-16 18:05 ` Eric Blake
2017-10-15 1:01 ` [Qemu-devel] [PATCH v4 2/8] nbd: Move nbd_errno_to_system_errno() to public header Eric Blake
2017-10-16 8:33 ` Vladimir Sementsov-Ogievskiy
2017-10-16 12:12 ` Eric Blake
2017-10-15 1:01 ` [Qemu-devel] [PATCH v4 3/8] nbd: Expose constants and structs for structured read Eric Blake
2017-10-16 8:49 ` Vladimir Sementsov-Ogievskiy
2017-10-16 12:15 ` Eric Blake
2017-10-15 1:01 ` [Qemu-devel] [PATCH v4 4/8] nbd: Minimal structured read for server Eric Blake
2017-10-16 9:49 ` Vladimir Sementsov-Ogievskiy
2017-10-16 12:18 ` Eric Blake
2017-10-16 15:41 ` Eric Blake [this message]
2017-10-16 19:29 ` Eric Blake
2017-10-15 1:01 ` [Qemu-devel] [PATCH v4 5/8] nbd/server: Include human-readable message in structured errors Eric Blake
2017-10-16 10:59 ` Vladimir Sementsov-Ogievskiy
2017-10-16 12:26 ` Eric Blake
2017-10-19 21:39 ` Eric Blake
2017-10-15 1:01 ` [Qemu-devel] [PATCH v4 6/8] nbd/client: refactor nbd_receive_starttls Eric Blake
2017-10-16 11:09 ` Vladimir Sementsov-Ogievskiy
2017-10-19 19:31 ` Eric Blake
2017-10-15 1:01 ` [Qemu-devel] [PATCH v4 7/8] nbd/client: prepare nbd_receive_reply for structured reply Eric Blake
2017-10-16 11:28 ` Vladimir Sementsov-Ogievskiy
2017-10-15 1:01 ` [Qemu-devel] [PATCH v4 8/8] nbd: Move nbd_read() to common header Eric Blake
2017-10-16 11:31 ` Vladimir Sementsov-Ogievskiy
2017-10-17 12:57 ` [Qemu-devel] [PATCH v4 RFC 9/8] nbd: Minimal structured read for client Vladimir Sementsov-Ogievskiy
2017-10-17 21:17 ` Eric Blake
2017-10-19 20:46 ` Eric Blake
2017-10-19 19:06 ` Eric Blake
2017-10-19 19:47 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bac1f011-2aa6-5b02-707b-bbb12b9a07fd@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).