From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F3EC4CEC9 for ; Sat, 14 Sep 2019 18:18:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5371120692 for ; Sat, 14 Sep 2019 18:18:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OWG9XGJZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5371120692 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9Cd5-0002b0-DK for qemu-devel@archiver.kernel.org; Sat, 14 Sep 2019 14:18:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49683) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9CbY-0001Ve-Sj for qemu-devel@nongnu.org; Sat, 14 Sep 2019 14:17:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9CbY-0006Dn-07 for qemu-devel@nongnu.org; Sat, 14 Sep 2019 14:17:04 -0400 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:40663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9CbX-0006BL-PV for qemu-devel@nongnu.org; Sat, 14 Sep 2019 14:17:03 -0400 Received: by mail-ed1-x544.google.com with SMTP id v38so29706121edm.7 for ; Sat, 14 Sep 2019 11:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=X/Kyf7dYtaqUSu8ByDG9rWgwKebFYKkdIdx1ypmMZ/o=; b=OWG9XGJZdvsV5UxbsSHFa3ZzBLXbOKz0GHLVrQhIPHEnNolhH6f/3kyUXq23WghvVI WL/kGQuunYeomXtdJzvTYOffC7ScqlWsFz8IibjIBUSN69ag+rskogPmEVrJpcqk7NRI 4oL0i0dqlOMcee2B6n5bTAjXLihDvIKnIWSNTd0FpUKUMj8JktM6k3uOkwEFYY6urrHO NTReWnKMbN0pUvCDwcV6J5et9HizqUx+gqM6Eqv7A2PfC2XR+xdQw0zQTXClbbztL+Rg kElv0yR3DKfxczipj1NXcaOP1VeC0MmMAsZH8hGEpCDx53ElB6mMCVv2wEcxj1Fa2s94 IFUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X/Kyf7dYtaqUSu8ByDG9rWgwKebFYKkdIdx1ypmMZ/o=; b=Azv2Sb/IEgkuA7RC+xH0TaOa5ue7Sloz/i4+SFESt1AeiyUy8cbpWyjKZ+7wwhCLTT nEbObttBwvdKzg5mHW67D9uyKplvGFWbA9nLg5/Zy7TXD/Ztk2tLBc/jat/5t/HB59QM qUOpGdjotWr95gutsIP08Z/FsWyTM6GmywEeZ1S+vSgfsDFVP7vWXSfcJBqXSeSY6Hkt hVqcb4sOfk24mFxmOIuH/ZK6Y2lqm0kBi7/nmSm1HBxDUZc19KfORwuG/m7Yq0KsSHTq YGPa1Rz8Y3r4HcAy4tILAPnR++pKS255Op7b7i9cZ39ng5JGZ3nXc9ZNaIhMUCSx0R9m bGpg== X-Gm-Message-State: APjAAAUKQpoyvqZveFcKLKMNqEVtcxe54z0ciKcqLbqYx5KQzDKMe4Dk HE+XbzOCgLkFNFxlRk2To6FoP56Gz+f0lA== X-Google-Smtp-Source: APXvYqwjEchJshBQc+B7kiCGgxi3upnAPIE+e6KSHLu9vi/XJPV4X8i3jgsrsClS042RLGtmqpXYTA== X-Received: by 2002:a50:cb8c:: with SMTP id k12mr46120379edi.94.1568485020047; Sat, 14 Sep 2019 11:17:00 -0700 (PDT) Received: from [192.168.44.107] ([185.81.138.21]) by smtp.gmail.com with ESMTPSA id j5sm5984212edj.62.2019.09.14.11.16.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Sep 2019 11:16:59 -0700 (PDT) To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , peter.maydell@linaro.org References: <20190910193408.28917-1-alex.bennee@linaro.org> <20190910193408.28917-4-alex.bennee@linaro.org> <878sqv1by6.fsf@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Sat, 14 Sep 2019 14:16:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <878sqv1by6.fsf@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 Subject: Re: [Qemu-devel] [PATCH v1 3/4] elf: move elf_ops.h into include/elf/ and rename X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/11/19 4:20 AM, Alex Bennée wrote: > Alex Bennée writes: > >> Lets keep all the Elf manipulation bits together. Also rename the file >> to better reflect how it is used and add a little header to the file. >> >> Signed-off-by: Alex Bennée >> --- >> hw/core/loader.c | 4 ++-- > It is arguable this could be a private header in hw/core as it is only > included in one place. > Let's leave it here. r~