From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgFTu-0008Oo-L1 for qemu-devel@nongnu.org; Thu, 19 Jul 2018 16:24:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgFTt-0005qz-Hr for qemu-devel@nongnu.org; Thu, 19 Jul 2018 16:24:58 -0400 References: <20180718211256.29774-1-naravamudan@digitalocean.com> From: John Snow Message-ID: Date: Thu, 19 Jul 2018 16:24:46 -0400 MIME-Version: 1.0 In-Reply-To: <20180718211256.29774-1-naravamudan@digitalocean.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block/file-posix: add bdrv_attach_aio_context callback for host dev and cdrom List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nishanth Aravamudan Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Farhan Ali , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , Paolo Bonzini On 07/18/2018 05:12 PM, Nishanth Aravamudan via Qemu-devel wrote: > In ed6e2161 ("linux-aio: properly bubble up errors from initialzation"), > I only added a bdrv_attach_aio_context callback for the bdrv_file > driver. There are several other drivers that use the shared > aio_plug callback, though, and they will trip the assertion added to > aio_get_linux_aio because they did not call aio_setup_linux_aio first. > Add the appropriate callback definition to the affected driver > definitions. > > Fixes: ed6e2161 ("linux-aio: properly bubble up errors from initialization") > Reported-by: Farhan Ali > Signed-off-by: Nishanth Aravamudan > Cc: Eric Blake > Cc: Kevin Wolf > Cc: John Snow > Cc: Max Reitz > Cc: Stefan Hajnoczi > Cc: Fam Zheng > Cc: Paolo Bonzini > Cc: qemu-block@nongnu.org > Cc: qemu-devel@nongnu.org > --- > block/file-posix.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/block/file-posix.c b/block/file-posix.c > index 60af4b3d51..ad299beb38 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -3158,6 +3158,7 @@ static BlockDriver bdrv_host_device = { > .bdrv_refresh_limits = raw_refresh_limits, > .bdrv_io_plug = raw_aio_plug, > .bdrv_io_unplug = raw_aio_unplug, > + .bdrv_attach_aio_context = raw_aio_attach_aio_context, > > .bdrv_co_truncate = raw_co_truncate, > .bdrv_getlength = raw_getlength, > @@ -3280,6 +3281,7 @@ static BlockDriver bdrv_host_cdrom = { > .bdrv_refresh_limits = raw_refresh_limits, > .bdrv_io_plug = raw_aio_plug, > .bdrv_io_unplug = raw_aio_unplug, > + .bdrv_attach_aio_context = raw_aio_attach_aio_context, > > .bdrv_co_truncate = raw_co_truncate, > .bdrv_getlength = raw_getlength, > @@ -3410,6 +3412,7 @@ static BlockDriver bdrv_host_cdrom = { > .bdrv_refresh_limits = raw_refresh_limits, > .bdrv_io_plug = raw_aio_plug, > .bdrv_io_unplug = raw_aio_unplug, > + .bdrv_attach_aio_context = raw_aio_attach_aio_context, > > .bdrv_co_truncate = raw_co_truncate, > .bdrv_getlength = raw_getlength, > Seems sane to me, at a glance. Reviewed-by: John Snow