* [Qemu-devel] [PATCH v2] io: fix mem leak in websock error path
@ 2017-10-12 13:25 Daniel P. Berrange
2017-10-12 13:53 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrange @ 2017-10-12 13:25 UTC (permalink / raw)
To: qemu-devel; +Cc: Eric Blake, Philippe Mathieu-Daudé, Daniel P. Berrange
Coverity pointed out the 'date' is not free()d in the error
path
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
io/channel-websock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/io/channel-websock.c b/io/channel-websock.c
index aa35ef3274..df2c3a9f99 100644
--- a/io/channel-websock.c
+++ b/io/channel-websock.c
@@ -341,7 +341,7 @@ static void qio_channel_websock_handshake_send_res_ok(QIOChannelWebsock *ioc,
char combined_key[QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN +
QIO_CHANNEL_WEBSOCK_GUID_LEN + 1];
char *accept = NULL;
- char *date = qio_channel_websock_date_str();
+ char *date = NULL;
g_strlcpy(combined_key, key, QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN + 1);
g_strlcat(combined_key, QIO_CHANNEL_WEBSOCK_GUID,
@@ -360,6 +360,7 @@ static void qio_channel_websock_handshake_send_res_ok(QIOChannelWebsock *ioc,
return;
}
+ date = qio_channel_websock_date_str();
qio_channel_websock_handshake_send_res(
ioc, QIO_CHANNEL_WEBSOCK_HANDSHAKE_RES_OK, date, accept);
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH v2] io: fix mem leak in websock error path
2017-10-12 13:25 [Qemu-devel] [PATCH v2] io: fix mem leak in websock error path Daniel P. Berrange
@ 2017-10-12 13:53 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2017-10-12 13:53 UTC (permalink / raw)
To: Daniel P. Berrange, qemu-devel; +Cc: Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]
On 10/12/2017 08:25 AM, Daniel P. Berrange wrote:
> Coverity pointed out the 'date' is not free()d in the error
> path
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> io/channel-websock.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/io/channel-websock.c b/io/channel-websock.c
> index aa35ef3274..df2c3a9f99 100644
> --- a/io/channel-websock.c
> +++ b/io/channel-websock.c
> @@ -341,7 +341,7 @@ static void qio_channel_websock_handshake_send_res_ok(QIOChannelWebsock *ioc,
> char combined_key[QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN +
> QIO_CHANNEL_WEBSOCK_GUID_LEN + 1];
> char *accept = NULL;
> - char *date = qio_channel_websock_date_str();
> + char *date = NULL;
>
> g_strlcpy(combined_key, key, QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN + 1);
> g_strlcat(combined_key, QIO_CHANNEL_WEBSOCK_GUID,
> @@ -360,6 +360,7 @@ static void qio_channel_websock_handshake_send_res_ok(QIOChannelWebsock *ioc,
> return;
> }
>
> + date = qio_channel_websock_date_str();
> qio_channel_websock_handshake_send_res(
> ioc, QIO_CHANNEL_WEBSOCK_HANDSHAKE_RES_OK, date, accept);
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-12 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 13:25 [Qemu-devel] [PATCH v2] io: fix mem leak in websock error path Daniel P. Berrange
2017-10-12 13:53 ` Eric Blake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).