From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH for-3.0 1/2] armv7m_nvic: Fix m-security subsection name
Date: Sat, 28 Jul 2018 09:42:53 -0700 [thread overview]
Message-ID: <bae88ea9-5bbd-8abf-fd29-258b578f11d1@linaro.org> (raw)
In-Reply-To: <20180727113854.20283-2-peter.maydell@linaro.org>
On 07/27/2018 04:38 AM, Peter Maydell wrote:
> The vmstate save/load code insists that subsections of a VMState must
> have names which include their parent VMState's name as a leading
> substring. Unfortunately it neither documents this nor checks it on
> device init or state save, but instead fails state load with a
> confusing error message ("Missing section footer for armv7m_nvic").
>
> Fix the name of the m-security subsection of the NVIC, so that
> state save/load works correctly for the security-enabled NVIC.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/intc/armv7m_nvic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-07-28 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 11:38 [Qemu-devel] [PATCH for-3.0 0/2] MPS/v8M bug fixes Peter Maydell
2018-07-27 11:38 ` [Qemu-devel] [PATCH for-3.0 1/2] armv7m_nvic: Fix m-security subsection name Peter Maydell
2018-07-28 16:42 ` Richard Henderson [this message]
2018-07-27 11:38 ` [Qemu-devel] [PATCH for-3.0 2/2] hw/arm/iotkit: Fix IRQ number for timer1 Peter Maydell
2018-07-27 12:05 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bae88ea9-5bbd-8abf-fd29-258b578f11d1@linaro.org \
--to=richard.henderson@linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).