From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Titus Rwantare <titusr@google.com>, minyard@acm.org, its@irrelevant.dk
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, clg@kaod.org
Subject: Re: [PATCH v2] hw/misc: i2c-echo: add tracing
Date: Wed, 22 Jan 2025 08:00:27 +0100 [thread overview]
Message-ID: <baf090cc-decd-4d6c-b857-f970b5acd766@linaro.org> (raw)
In-Reply-To: <20250121105935.3069035-1-titusr@google.com>
On 21/1/25 11:59, Titus Rwantare wrote:
> This has been useful when debugging and unsure if the guest is
> generating i2c traffic.
>
> Signed-off-by: Titus Rwantare <titusr@google.com>
> ---
> hw/misc/i2c-echo.c | 8 ++++++++
> hw/misc/trace-events | 5 +++++
> 2 files changed, 13 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> +#i2c-echo.c
> +i2c_echo_event(const char *id, const char *event) "%s: %s"
> +i2c_echo_recv(const char *id, uint8_t data) "%s: recv 0x%" PRIx8
> +i2c_echo_send(const char *id, uint8_t data) "%s: send 0x%" PRIx8
and queued using 0x02% format, thanks!
Phil.
next prev parent reply other threads:[~2025-01-22 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 10:59 [PATCH v2] hw/misc: i2c-echo: add tracing Titus Rwantare
2025-01-22 6:38 ` Hao Wu
2025-01-22 7:00 ` Philippe Mathieu-Daudé [this message]
2025-01-22 12:46 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf090cc-decd-4d6c-b857-f970b5acd766@linaro.org \
--to=philmd@linaro.org \
--cc=clg@kaod.org \
--cc=its@irrelevant.dk \
--cc=minyard@acm.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).