From: Eric Blake <eblake@redhat.com>
To: "Yasmin Beatriz" <yasmins@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-trivial@nongnu.org, joserz@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2] dump: Show custom message for ENOSPC
Date: Fri, 9 Feb 2018 14:57:33 -0600 [thread overview]
Message-ID: <baf09d46-934f-1f82-1f68-21ae22ffd2f9@redhat.com> (raw)
In-Reply-To: <20180209202621.97852-1-yasmins@linux.vnet.ibm.com>
On 02/09/2018 02:26 PM, Yasmin Beatriz wrote:
> This patch intends to make a more specific message for when
> the system has not enough space to save guest memory.
>
> Reported-by: yilzhang@redhat.com
> Cc: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
> Signed-off-by: Yasmin Beatriz <yasmins@linux.vnet.ibm.com>
> ---
> @@ -364,7 +364,11 @@ static void write_data(DumpState *s, void *buf, int length, Error **errp)
>
> ret = fd_write_vmcore(buf, length, s);
> if (ret < 0) {
> - error_setg(errp, "dump: failed to save memory");
> + if (ret == -ENOSPC) {
> + error_setg(errp, "dump: not enough space to save memory");
> + } else {
> + error_setg(errp, "dump: failed to save memory");
> + }
Why is this caller the only one in the file that gets distinguished
error messages? And why not use error_setg_errno() instead of
open-coding just one special errno value? If you're changing the return
value of fd_write_vmcore() anyways, I'd suggest that ALL callers in the
file be updated to use error_setg_errno().
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-02-09 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 20:26 [Qemu-devel] [PATCH v2] dump: Show custom message for ENOSPC Yasmin Beatriz
2018-02-09 20:32 ` Daniel Henrique Barboza
2018-02-09 20:57 ` Eric Blake [this message]
2018-02-09 21:36 ` joserz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf09d46-934f-1f82-1f68-21ae22ffd2f9@redhat.com \
--to=eblake@redhat.com \
--cc=joserz@linux.vnet.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=yasmins@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).