qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] migration/rdma: Remove deprecated variable rdma_return_path
       [not found] <20230315012247.9007-1-lizhijian@fujitsu.com>
@ 2023-03-16  8:51 ` lizhijian
  2023-03-16  9:59   ` Juan Quintela
  0 siblings, 1 reply; 2+ messages in thread
From: lizhijian @ 2023-03-16  8:51 UTC (permalink / raw)
  To: quintela@redhat.com, dgilbert@redhat.com; +Cc: qemu-devel@nongnu.org


Not clear why it doesn't appear in the archive(https://lists.gnu.org/archive/html/qemu-devel/2023-03/threads.html)

nop...


On 15/03/2023 09:22, Li Zhijian wrote:
> It's no longer needed since commit
> 44bcfd45e98 ("migration/rdma: destination: create the return patch after the first accept")
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>   migration/rdma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/migration/rdma.c b/migration/rdma.c
> index f5d3bbe7e9c..2bc2fcf727b 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -4214,7 +4214,7 @@ static void rdma_accept_incoming_migration(void *opaque)
>   void rdma_start_incoming_migration(const char *host_port, Error **errp)
>   {
>       int ret;
> -    RDMAContext *rdma, *rdma_return_path = NULL;
> +    RDMAContext *rdma;
>       Error *local_err = NULL;
>   
>       trace_rdma_start_incoming_migration();
> @@ -4260,7 +4260,6 @@ err:
>           g_free(rdma->host_port);
>       }
>       g_free(rdma);
> -    g_free(rdma_return_path);
>   }
>   
>   void rdma_start_outgoing_migration(void *opaque,

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] migration/rdma: Remove deprecated variable rdma_return_path
  2023-03-16  8:51 ` [PATCH] migration/rdma: Remove deprecated variable rdma_return_path lizhijian
@ 2023-03-16  9:59   ` Juan Quintela
  0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2023-03-16  9:59 UTC (permalink / raw)
  To: lizhijian; +Cc: dgilbert@redhat.com, qemu-devel@nongnu.org

"lizhijian@fujitsu.com" <lizhijian@fujitsu.com> wrote:
> Not clear why it doesn't appear in the archive(https://lists.gnu.org/archive/html/qemu-devel/2023-03/threads.html)

No clue either.

> nop...




>
>
> On 15/03/2023 09:22, Li Zhijian wrote:
>> It's no longer needed since commit
>> 44bcfd45e98 ("migration/rdma: destination: create the return patch after the first accept")
>> 
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> ---
>>   migration/rdma.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/migration/rdma.c b/migration/rdma.c
>> index f5d3bbe7e9c..2bc2fcf727b 100644
>> --- a/migration/rdma.c
>> +++ b/migration/rdma.c
>> @@ -4214,7 +4214,7 @@ static void rdma_accept_incoming_migration(void *opaque)
>>   void rdma_start_incoming_migration(const char *host_port, Error **errp)
>>   {
>>       int ret;
>> -    RDMAContext *rdma, *rdma_return_path = NULL;
>> +    RDMAContext *rdma;
>>       Error *local_err = NULL;
>>   
>>       trace_rdma_start_incoming_migration();
>> @@ -4260,7 +4260,6 @@ err:
>>           g_free(rdma->host_port);
>>       }
>>       g_free(rdma);
>> -    g_free(rdma_return_path);
>>   }
>>   
>>   void rdma_start_outgoing_migration(void *opaque,

Reviewed-by: Juan Quintela <quintela@redhat.com>

Regenerating it on my local tree and queuing.

Thanks,



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-16  9:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20230315012247.9007-1-lizhijian@fujitsu.com>
2023-03-16  8:51 ` [PATCH] migration/rdma: Remove deprecated variable rdma_return_path lizhijian
2023-03-16  9:59   ` Juan Quintela

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).