From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Emilio G . Cota" <cota@braap.org>,
"Richard Henderson" <rth@twiddle.net>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 1/2] hw/isa/smc37c669-superio: Basic 'Config Registers' implementation
Date: Thu, 14 Jun 2018 20:19:25 +0200 [thread overview]
Message-ID: <bafda81a-a33b-6137-b30a-1cf98ab8393b@redhat.com> (raw)
In-Reply-To: <20180614180119.1704-2-f4bug@amsat.org>
On 14/06/2018 20:01, Philippe Mathieu-Daudé wrote:
> +
> +static Property smc37c669_properties[] = {
> + DEFINE_PROP_UINT32("config", SMC37C669State, config, 0x78889c28),
> + DEFINE_PROP_BIT("parallel", SMC37C669State, config, 8 + 2, true),
> + DEFINE_PROP_END_OF_LIST()
> +};
I would initialize the config word in instance_init rather
than using a property. Having overlapping properties for the same field
sounds like a recipe for undesired behavior.
But why isn't the parallel port at 0x378? That's the expected place on
PC (the second parallel port is at 0x278 and the third is at 0x3bc), and
I would expect other SuperIO chips to have it there too. That would be
a one line fix.
Yet another possibility is to disable EPP on the parallel port, so that
it occupies only the addresses from 0x3bc to 0x3be.
Paolo
next prev parent reply other threads:[~2018-06-14 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 18:01 [Qemu-devel] [RFC PATCH 0/2] smc37c669: Fix parallel overlapping VGA ioport Philippe Mathieu-Daudé
2018-06-14 18:01 ` [Qemu-devel] [RFC PATCH 1/2] hw/isa/smc37c669-superio: Basic 'Config Registers' implementation Philippe Mathieu-Daudé
2018-06-14 18:19 ` Paolo Bonzini [this message]
2018-06-14 21:14 ` Richard Henderson
2018-06-14 21:24 ` Paolo Bonzini
2018-06-14 18:01 ` [Qemu-devel] [RFC PATCH 2/2] hw/alpha/dp264: Disable the Super I/O parallel port Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bafda81a-a33b-6137-b30a-1cf98ab8393b@redhat.com \
--to=pbonzini@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).