From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btcfp-0008Sd-N3 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 11:39:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btcfn-0005A0-P9 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 11:39:28 -0400 References: <1476106902-27337-1-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: Date: Mon, 10 Oct 2016 17:39:16 +0200 MIME-Version: 1.0 In-Reply-To: <1476106902-27337-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J0lTrxB4qMW9XaxpM0bg2Fir4bbhSO4oX" Subject: Re: [Qemu-devel] [PATCH v2] block: Remove "options" indirection from blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: eblake@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --J0lTrxB4qMW9XaxpM0bg2Fir4bbhSO4oX From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: eblake@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org Message-ID: Subject: Re: [PATCH v2] block: Remove "options" indirection from blockdev-add References: <1476106902-27337-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1476106902-27337-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 10.10.2016 15:41, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level= > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains th= e > real arguments. >=20 > blockdev-add is still experimental and we already made substantial > changes to the API recently, so we're free to make changes like this > one, too. >=20 > Signed-off-by: Kevin Wolf > --- >=20 > v2: > - Updated some documentation in docs/qmp-commands.txt and > qapi/block-core.json [Max] In qmp-commands.txt, there is still a blockdev-add example with "options" under x-blockdev-change, and the blockdev-add documentation itself still says that blockdev-add takes an argument named "options". Max > docs/qmp-commands.txt | 72 ++++++++++++++---------------- > qapi/block-core.json | 4 +- > tests/qemu-iotests/041 | 11 +++-- > tests/qemu-iotests/067 | 12 +++-- > tests/qemu-iotests/071 | 118 +++++++++++++++++++++--------------------= -------- > tests/qemu-iotests/081 | 52 ++++++++++------------ > tests/qemu-iotests/085 | 9 ++-- > tests/qemu-iotests/087 | 76 +++++++++++++------------------ > tests/qemu-iotests/117 | 12 ++--- > tests/qemu-iotests/118 | 42 +++++++++--------- > tests/qemu-iotests/124 | 20 ++++----- > tests/qemu-iotests/139 | 10 ++--- > tests/qemu-iotests/141 | 13 +++--- > tests/qemu-iotests/155 | 10 ++--- > 14 files changed, 209 insertions(+), 252 deletions(-) --J0lTrxB4qMW9XaxpM0bg2Fir4bbhSO4oX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJX+7YkEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQPaR CAC/bu3qkVpDBds5X445GeBGC9chkCYGH+XkK662RJsqtNw5/6jKnaQZOmga4mHr FE6FD47T4VaZvcdf4tzwwLZjeP1V0r0xUMJxz9ErOsLUfTRPl9ZmPdKeIrATclt/ Jd9JRFtv+m9AyCNA9D7FS5YhDvawx0PuvBmke2qUOQl4Cc+zdhIBcwahlEdk5Aik rAzeaUTmMqZtFRKaphDP8bEJFDpYz3Zd474F5O5v4Ay0jA1hWpeHTKqPnKGeboVA GiRaq2RIn5updFC9O0AVsiS2PgUw9ulsl7hGZ36COaWktdOVntiq0RbAPjwjTjNb H6wp6fBDjBFCoFB5hx4FcEZ2 =MSPe -----END PGP SIGNATURE----- --J0lTrxB4qMW9XaxpM0bg2Fir4bbhSO4oX--