From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbq7e-0004vp-MH for qemu-devel@nongnu.org; Mon, 22 Aug 2016 10:22:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbq7b-00022i-Bp for qemu-devel@nongnu.org; Mon, 22 Aug 2016 10:22:42 -0400 Received: from mx1.parallels.com ([199.115.104.18]:56316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbq7b-0001zz-60 for qemu-devel@nongnu.org; Mon, 22 Aug 2016 10:22:39 -0400 References: <1471265656-11227-1-git-send-email-stefanha@redhat.com> From: "Denis V. Lunev" Message-ID: Date: Mon, 22 Aug 2016 10:00:31 -0400 MIME-Version: 1.0 In-Reply-To: <1471265656-11227-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Cornelia Huck , Fam Zheng , "Michael S. Tsirkin" On 08/15/2016 08:54 AM, Stefan Hajnoczi wrote: > The VirtQueue->inuse field is not always updated correctly. These patches fix > it. > > Originally this series was called "virtio-balloon: fix stats vq migration" but > Ladi Prosek posted a nicer fix called "balloon: Fix failure of updating guest > memory status". I dropped the virtio-balloon patches. > > Changes from previous series: > * Missing comma in error formatting [Fam] > * virtio_descard() -> virtio_discard() [Michael] > * Multi-line comment style [Cornelia] > > Stefan Hajnoczi (2): > virtio: recalculate vq->inuse after migration > virtio: decrement vq->inuse in virtqueue_discard() > > hw/virtio/virtio.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > these patches break 'make check' with the following: GTESTER check-qtest-x86_64 Warning: path not on HugeTLBFS: /tmp/vhost-test-hRYeTb Warning: path not on HugeTLBFS: /tmp/vhost-test-hRYeTb Warning: path not on HugeTLBFS: /tmp/vhost-test-hRYeTb qemu-system-x86_64: VQ 1 size 0x100 < last_avail_idx 0x0 - used_idx 0x1 qemu-system-x86_64: error while loading state for instance 0x0 of device '0000:00:03.0/virtio-net' qemu-system-x86_64: load of migration failed: Operation not permitted Broken pipe qemu-system-x86_64: Failed to read msg header. Read 0 instead of 12. Original request 11. GTester: last random seed: R02S122f07a3fc35cfd5b0204e3eb45c61e6 qemu-system-x86_64: Failed to read msg header. Read 0 instead of 12. Original request 11. Warning: path not on HugeTLBFS: /tmp/vhost-test-60WtDz blkdebug: Suspended request 'A' blkdebug: Resuming request 'A' main-loop: WARNING: I/O thread spun for 1000 iterations main-loop: WARNING: I/O thread spun for 1000 iterations /home/den/src/git/qemu/tests/Makefile:400: recipe for target 'check-qtest-x86_64' failed make: *** [check-qtest-x86_64] Error 1 iris ~/src/git/qemu $ Sorry, if I have missed the fix in the list. Den