qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org,
	"Francisco Iglesias" <frasse.iglesias@gmail.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"KONRAD Frederic" <frederic.konrad@adacore.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Emilio G. Cota" <cota@braap.org>
Subject: Re: [Qemu-devel] [RFC PATCH] mmio-exec: Make device return MemoryRegion rather than host pointer
Date: Mon, 30 Apr 2018 12:46:45 +0200	[thread overview]
Message-ID: <bb113306-8c1c-e414-18d1-3337f1521f5e@redhat.com> (raw)
In-Reply-To: <20180426150901.30278-1-peter.maydell@linaro.org>

On 26/04/2018 17:09, Peter Maydell wrote:
> 
> QUESTIONS:
>  * do we really need to postpone things from
>    memory_region_invalidate_mmio_ptr() to
>    memory_region_do_invalidate_mmio_ptr(), given that the deletion of
>    the memory region and ramblock is RCU-deferred anyway?
>  * should we add the subregion at elevated prio so it definitely hits
>    first?  I've left it the way the existing code does for the
>    moment...
>  * is there any way to avoid the weird self-owning MemoryRegion
>    and corresponding need to pass a NULL name pointer?

There would be, but the comment here says why it'd be an issue:

    /* Memory regions without an owner are supposed to never go away;
     * we do not ref/unref them because it slows down DMA sensibly.
     */
    if (mr && mr->owner) {
        object_ref(mr->owner);
    }

though perhaps we can remove that other hack in 2.13, which will have
MemoryRegionCache again.

Paolo

  reply	other threads:[~2018-04-30 10:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 15:09 [Qemu-devel] [RFC PATCH] mmio-exec: Make device return MemoryRegion rather than host pointer Peter Maydell
2018-04-30 10:46 ` Paolo Bonzini [this message]
2018-04-30 12:52 ` KONRAD Frederic
2018-05-28  5:22 ` Cédric Le Goater
2018-05-28 15:25   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb113306-8c1c-e414-18d1-3337f1521f5e@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=clg@kaod.org \
    --cc=cota@braap.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=frasse.iglesias@gmail.com \
    --cc=frederic.konrad@adacore.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).