From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] freebsd: use python37
Date: Mon, 6 Jan 2020 14:19:07 +0100 [thread overview]
Message-ID: <bb1948f0-e9df-f250-cad4-825c985b3141@redhat.com> (raw)
In-Reply-To: <20200106123746.18201-1-kraxel@redhat.com>
On 1/6/20 1:37 PM, Gerd Hoffmann wrote:
> FreeBSD seems to use python37 by default now, which breaks the build
> script. Add python to the package list, to explicitly pick the version,
> and also adapt the configure command line.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> tests/vm/freebsd | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 1825cc58218b..33a736298a9a 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
> "git",
> "pkgconf",
> "bzip2",
> + "python37",
>
> # gnu tools
> "bash",
> @@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
> mkdir src build; cd src;
> tar -xf /dev/vtbd1;
> cd ../build
> - ../src/configure --python=python3.6 {configure_opts};
> + ../src/configure --python=python3.7 {configure_opts};
> gmake --output-sync -j{jobs} {target} {verbose};
> """
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-01-06 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 12:37 [PATCH] freebsd: use python37 Gerd Hoffmann
2020-01-06 13:19 ` Philippe Mathieu-Daudé [this message]
2020-01-06 13:21 ` Philippe Mathieu-Daudé
2020-01-07 11:11 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb1948f0-e9df-f250-cad4-825c985b3141@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).