From: Matthew Rosato <mjrosato@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: Re: [PATCH for 7.2 0/2] s390x/s390-virtio-ccw:
Date: Mon, 7 Nov 2022 11:49:31 -0500 [thread overview]
Message-ID: <bb2b3509-cd22-be00-a78e-c18f324e4b3f@linux.ibm.com> (raw)
In-Reply-To: <20221107161349.1032730-1-clg@kaod.org>
On 11/7/22 11:13 AM, Cédric Le Goater wrote:
> From: Cédric Le Goater <clg@redhat.com>
>
> Hello,
>
> This series removes the redundant "zpcii-disable" machine property and
> and introduces a GlobalProperty compat array to maintain the same
> behaviour on older machines.
>
> Thanks,
>
> C.
Thanks Cedric.
For the series:
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Also did a quick test on top of
https://gitlab.com/thuth/qemu.git tags/pull-request-2022-11-06
to verify that zPCI interpretation/forwarding is available as expected with machine 7.2 and off by default in 7.1 and older.
>
> Cédric Le Goater (2):
> Revert "s390x/s390-virtio-ccw: add zpcii-disable machine property"
> s390x/s390-virtio-ccw: Switch off zPCI enhancements on older machines
>
> include/hw/s390x/s390-virtio-ccw.h | 1 -
> hw/s390x/s390-pci-kvm.c | 4 +---
> hw/s390x/s390-virtio-ccw.c | 29 +++++------------------------
> util/qemu-config.c | 4 ----
> qemu-options.hx | 8 +-------
> 5 files changed, 7 insertions(+), 39 deletions(-)
>
prev parent reply other threads:[~2022-11-07 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 16:13 [PATCH for 7.2 0/2] s390x/s390-virtio-ccw: Cédric Le Goater
2022-11-07 16:13 ` [PATCH for 7.2 1/2] Revert "s390x/s390-virtio-ccw: add zpcii-disable machine property" Cédric Le Goater
2022-11-07 16:13 ` [PATCH for 7.2 2/2] s390x/s390-virtio-ccw: Switch off zPCI enhancements on older machines Cédric Le Goater
2022-11-07 16:49 ` Matthew Rosato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb2b3509-cd22-be00-a78e-c18f324e4b3f@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=clg@kaod.org \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).