From: Thomas Huth <thuth@redhat.com>
To: Lev Kujawski <lkujaw@member.fsf.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 2/2] tests/qtest/i440fx-test.c: Enable full test of i440FX PAM operation
Date: Fri, 17 Jun 2022 09:40:22 +0200 [thread overview]
Message-ID: <bb340919-94e5-ff28-3f50-15da59cf4e7f@redhat.com> (raw)
In-Reply-To: <20220616100530.716590-2-lkujaw@member.fsf.org>
On 16/06/2022 12.05, Lev Kujawski wrote:
> With the prior patch in this series adding support for RE^WE PAM
> semantics, the '#ifndef BROKEN' segments of test_i440fx_pam can now be
> enabled.
>
> Additionally:
> - Verify that changing attributes does not affect the initial contents
> of the PAM region;
> - Verify that that the first new mask is written before switching
> attributes;
> - Switch back to PAM_RE after PAM_WE to read original contents;
> - Tighten logic of the !WE write test because we know what the
> original contents were; and
> - Write the last mask before testing for it.
>
> Signed-off-by: Lev Kujawski <lkujaw@member.fsf.org>
> ---
> (v2) No change.
>
> tests/qtest/i440fx-test.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
Acked-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2022-06-17 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 10:05 [PATCH v2 1/2] hw/pci-host/pam.c: Fully support RE^WE semantics of i440FX PAM Lev Kujawski
2022-06-16 10:05 ` [PATCH v2 2/2] tests/qtest/i440fx-test.c: Enable full test of i440FX PAM operation Lev Kujawski
2022-06-17 7:40 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb340919-94e5-ff28-3f50-15da59cf4e7f@redhat.com \
--to=thuth@redhat.com \
--cc=lkujaw@member.fsf.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).