From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
Alistair Francis <alistair@alistair23.me>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro
Date: Tue, 30 Oct 2018 15:26:22 +0100 [thread overview]
Message-ID: <bb6a600f-861e-57dd-0bdb-108eccbaf7fa@redhat.com> (raw)
In-Reply-To: <CAFEAcA-yrZY3QD7ecOkQHU18qnU2y=G-QP+=ZZMhhnKTWwoVVw@mail.gmail.com>
On 30/10/18 15:07, Peter Maydell wrote:
> On 30 October 2018 at 11:40, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> hw/arm/xilinx_zynq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
>> index f1496d2927..57497b0c4d 100644
>> --- a/hw/arm/xilinx_zynq.c
>> +++ b/hw/arm/xilinx_zynq.c
>> @@ -294,7 +294,7 @@ static void zynq_init(MachineState *machine)
>> busdev = SYS_BUS_DEVICE(dev);
>> sysbus_mmio_map(busdev, 0, 0xF8003000);
>> sysbus_connect_irq(busdev, 0, pic[45-IRQ_OFFSET]); /* abort irq line */
>> - for (n = 0; n < 8; ++n) { /* event irqs */
>> + for (n = 0; n < ARRAY_SIZE(dma_irqs); ++n) { /* event irqs */
>> sysbus_connect_irq(busdev, n + 1, pic[dma_irqs[n] - IRQ_OFFSET]);
>> }
>>
>> --
>> 2.17.2
>
> Since this isn't related to the other patch, I'll just apply
> it to target-arm.next to save you carrying it around.
Thank you!
next prev parent reply other threads:[~2018-10-30 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 11:40 [Qemu-devel] [PATCH v2 0/2] hw/arm/exynos4: Add DMA support for SMDKC210 board Philippe Mathieu-Daudé
2018-10-30 11:40 ` [Qemu-devel] [PATCH v2 1/2] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro Philippe Mathieu-Daudé
2018-10-30 14:07 ` Peter Maydell
2018-10-30 14:26 ` Philippe Mathieu-Daudé [this message]
2018-10-30 11:40 ` [Qemu-devel] [PATCH v2 2/2] arm: exynos4: Add dma support for smdkc210 Philippe Mathieu-Daudé
2018-10-30 14:06 ` Peter Maydell
2018-10-30 14:27 ` Philippe Mathieu-Daudé
2018-10-31 11:20 ` [Qemu-devel] [PATCH v2 0/2] hw/arm/exynos4: Add DMA support for SMDKC210 board no-reply
2018-10-31 16:00 ` Philippe Mathieu-Daudé
2018-11-01 17:18 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6a600f-861e-57dd-0bdb-108eccbaf7fa@redhat.com \
--to=philmd@redhat.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=i.mitsyanko@gmail.com \
--cc=linux@roeck-us.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).