From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bin Meng <bmeng.cn@gmail.com>, QEMU <qemu-devel@nongnu.org>
Cc: Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 0/2] hw/sd: Fix broken ssi-sd implementation since v9.1.0
Date: Mon, 10 Nov 2025 12:57:36 +0100 [thread overview]
Message-ID: <bb8eedd0-b061-416f-be49-33a760c6e1f7@linaro.org> (raw)
In-Reply-To: <20251110110507.1641042-1-bmeng.cn@gmail.com>
Hi Bin, Tom,
On 10/11/25 12:05, Bin Meng wrote:
>
> The U-Boot community reported a CI failure [1] where the
> `sifive_unleashed` target failed to boot from an SD card after
> upgrading from QEMU v8.2.0 to v9.2.3.
>
> At that time, the issue was traced to commit da954d0e
> ("hw/sd/sdcard: Add spi_cmd_SEND_CSD/CID handlers (CMD9 & CMD10)")
> which was introduced in v9.1.0.
>
> Testing with the latest QEMU mainline shows that the problem still
> persists, although the underlying cause has changed due to refactoring
> since then.
>
> This series fixes the broken `ssi-sd` model. After applying these
> patches, U-Boot successfully boots again on the `sifive_unleashed`
> target using QEMU’s `sifive_u` machine.
Thanks for fixing this issue!
Do you mind adding this test as a functional one, so we get this
code path covered?
>
> [1] https://gitlab.com/qemu-project/qemu/-/issues/2945
>
>
> Bin Meng (2):
> hw/sd: Fix incorrect idle state reporting in R1 response for SPI mode
> hw/sd: Fix ACMD41 state machine in SPI mode
>
> hw/sd/sd.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
next prev parent reply other threads:[~2025-11-10 12:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 11:05 [PATCH 0/2] hw/sd: Fix broken ssi-sd implementation since v9.1.0 Bin Meng
2025-11-10 11:05 ` [PATCH 1/2] hw/sd: Fix incorrect idle state reporting in R1 response for SPI mode Bin Meng
2025-11-12 7:55 ` Philippe Mathieu-Daudé
2025-11-10 11:05 ` [PATCH 2/2] hw/sd: Fix ACMD41 state machine in " Bin Meng
2025-11-18 18:19 ` Philippe Mathieu-Daudé
2025-11-10 11:57 ` Philippe Mathieu-Daudé [this message]
2025-11-10 13:16 ` [PATCH 0/2] hw/sd: Fix broken ssi-sd implementation since v9.1.0 Bin Meng
2025-11-18 18:19 ` Philippe Mathieu-Daudé
2025-11-19 10:44 ` Michael Tokarev
2025-11-19 10:52 ` Michael Tokarev
2025-11-19 14:31 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb8eedd0-b061-416f-be49-33a760c6e1f7@linaro.org \
--to=philmd@linaro.org \
--cc=bmeng.cn@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).