From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 04/10] configure: do not set bsd_user/linux_user early
Date: Fri, 17 Dec 2021 12:49:24 -0800 [thread overview]
Message-ID: <bbb9e84a-da68-2642-603f-29748ab6d65c@linaro.org> (raw)
In-Reply-To: <20211216085139.99682-5-pbonzini@redhat.com>
On 12/16/21 12:51 AM, Paolo Bonzini wrote:
> @@ -541,7 +541,6 @@ gnu/kfreebsd)
> ;;
> freebsd)
> bsd="yes"
> - bsd_user="yes"
> make="${MAKE-gmake}"
> # needed for kinfo_getvmmap(3) in libutil.h
> ;;
> @@ -586,7 +585,6 @@ haiku)
> ;;
> linux)
> linux="yes"
> - linux_user="yes"
> vhost_user=${default_feature:-yes}
> ;;
> esac
...
> +if [ "$linux_user" != no ]; then
> + if [ "$targetos" = linux ] && [ -d $source_path/linux-user/host/$cpu ]; then
> + linux_user=yes
> + elif [ "$linux_user" = yes ]; then
> + error_exit "linux-user not supported on this architecture"
> + fi
> +fi
> +if [ "$bsd_user" != no ]; then
> + if [ -d $source_path/bsd-user/$targetos ]; then
> + bsd_user=yes
> + elif [ "$bsd_user" = yes ]; then
> + error_exit "bsd-user not supported on this host OS"
> + fi
> +fi
Missing the check for $targetos = freebsd.
This looks like it would enable bsd_user on linux, etc.
r~
next prev parent reply other threads:[~2021-12-17 20:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 8:51 [PATCH 00/10] configure cleanups, mostly wrt $cpu and $targetos Paolo Bonzini
2021-12-16 8:51 ` [PATCH 01/10] configure: simplify creation of plugin symbol list Paolo Bonzini
2021-12-17 20:42 ` Richard Henderson
2021-12-16 8:51 ` [PATCH 02/10] configure: make $targetos lowercase, use windows instead of MINGW32 Paolo Bonzini
2021-12-17 20:44 ` Richard Henderson
2021-12-16 8:51 ` [PATCH 03/10] configure: move target detection before CPU detection Paolo Bonzini
2021-12-16 8:51 ` [PATCH 04/10] configure: do not set bsd_user/linux_user early Paolo Bonzini
2021-12-17 20:49 ` Richard Henderson [this message]
2021-12-18 10:16 ` Paolo Bonzini
2021-12-16 8:51 ` [PATCH 05/10] configure: unify two case statements on $cpu Paolo Bonzini
2021-12-17 21:37 ` Richard Henderson
2021-12-16 8:51 ` [PATCH 06/10] configure: unify ppc64 and ppc64le Paolo Bonzini
2021-12-16 9:06 ` Philippe Mathieu-Daudé
2021-12-17 21:43 ` Richard Henderson
2021-12-16 8:51 ` [PATCH 07/10] configure: unify x86_64 and x32 Paolo Bonzini
2021-12-16 9:10 ` Philippe Mathieu-Daudé
2021-12-16 15:30 ` Paolo Bonzini
2021-12-17 21:48 ` Richard Henderson
2021-12-20 9:52 ` Philippe Mathieu-Daudé
2021-12-17 21:46 ` Richard Henderson
2021-12-16 8:51 ` [PATCH 08/10] meson: rename "arch" variable Paolo Bonzini
2021-12-16 9:10 ` Philippe Mathieu-Daudé
2021-12-17 21:49 ` Richard Henderson
2021-12-16 8:51 ` [PATCH 09/10] configure, meson: move ARCH to meson.build Paolo Bonzini
2021-12-17 22:02 ` Richard Henderson
2021-12-16 8:51 ` [PATCH 10/10] configure: remove unnecessary symlinks Paolo Bonzini
2021-12-17 22:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbb9e84a-da68-2642-603f-29748ab6d65c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).