From: Richard Henderson <richard.henderson@linaro.org>
To: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>, qemu-devel@nongnu.org
Cc: Alistair.Francis@wdc.com, palmer@dabbelt.com,
bin.meng@windriver.com, liweiwei@iscas.ac.cn,
dbarboza@ventanamicro.com, qemu-riscv@nongnu.org
Subject: Re: [PATCH 3/4] target/riscv: Encode the FS and VS on a normal way for tb flags
Date: Fri, 24 Mar 2023 10:03:10 -0700 [thread overview]
Message-ID: <bbba44c7-d527-8b9b-9dbf-c62172b27a24@linaro.org> (raw)
In-Reply-To: <20230324055954.908-4-zhiwei_liu@linux.alibaba.com>
On 3/23/23 22:59, LIU Zhiwei wrote:
> Reuse the MSTATUS_FS and MSTATUS_VS for the tb flags positions is not a normal
> way.
>
> It will make us change the tb flags layout difficult. And even worse, if we
> want to keep tb flags for a same extension togather without a hole.
>
> Signed-off-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> + flags = FIELD_DP32(flags, TB_FLAGS, FS, EXT_STATUS_DIRTY);
> + flags = FIELD_DP32(flags, TB_FLAGS, VS, EXT_STATUS_DIRTY);
...
> + flags = FIELD_DP32(flags, TB_FLAGS, FS,
...
> + flags = FIELD_DP32(flags, TB_FLAGS, VS,
Extra space after =.
r~
next prev parent reply other threads:[~2023-03-24 17:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 5:59 [PATCH 0/4] Fix tb flags use LIU Zhiwei
2023-03-24 5:59 ` [PATCH 1/4] target/riscv: Extract virt enabled state from tb flags LIU Zhiwei
2023-03-24 12:46 ` liweiwei
2023-03-24 17:00 ` Richard Henderson
2023-03-24 5:59 ` [PATCH 2/4] target/riscv: Add a general status enum for extensions LIU Zhiwei
2023-03-24 12:53 ` liweiwei
2023-03-24 13:47 ` LIU Zhiwei
2023-03-24 5:59 ` [PATCH 3/4] target/riscv: Encode the FS and VS on a normal way for tb flags LIU Zhiwei
2023-03-24 12:58 ` liweiwei
2023-03-24 17:03 ` Richard Henderson [this message]
2023-03-24 5:59 ` [PATCH 4/4] target/riscv: Add a tb flags field for vstart LIU Zhiwei
2023-03-24 13:02 ` liweiwei
2023-03-24 17:05 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbba44c7-d527-8b9b-9dbf-c62172b27a24@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).