From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kkostiuk@redhat.com, michael.roth@amd.com, eblake@redhat.com
Subject: Re: [PATCH 2/2] qga: Improve error for guest-set-user-password parameter @crypted
Date: Wed, 11 Sep 2024 17:13:36 +0200 [thread overview]
Message-ID: <bbcd989b-be54-41eb-8c8f-7d79c9ee8e2b@linaro.org> (raw)
In-Reply-To: <20240911131206.2503035-3-armbru@redhat.com>
On 11/9/24 15:12, Markus Armbruster wrote:
> The Windows version of guest-set-user-password rejects argument
> "crypted": true with the rather useless "this feature or command is
> not currently supported". Improve to "'crypted' must be off on this
> host".
>
> QERR_UNSUPPORTED is now unused. Drop.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qapi/qmp/qerror.h | 3 ---
> qga/commands-win32.c | 2 +-
> 2 files changed, 1 insertion(+), 4 deletions(-)
\o/
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-09-11 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 13:12 [PATCH 0/2] Finish eliminating QERR_UNSUPPORTED Markus Armbruster
2024-09-11 13:12 ` [PATCH 1/2] qga/qapi-schema: Drop obsolete note on "unsupported" errors Markus Armbruster
2024-09-12 7:55 ` Konstantin Kostiuk
2024-09-11 13:12 ` [PATCH 2/2] qga: Improve error for guest-set-user-password parameter @crypted Markus Armbruster
2024-09-11 15:13 ` Philippe Mathieu-Daudé [this message]
2024-09-12 7:55 ` Konstantin Kostiuk
2024-10-02 7:48 ` [PATCH 0/2] Finish eliminating QERR_UNSUPPORTED Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbcd989b-be54-41eb-8c8f-7d79c9ee8e2b@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).